feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use unique_ptr to hold targets in projects

Browse Source 
Change-Id: I8f793f5e552b65939d6c7c5e0eb42b89f9f45c3d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-24 12:57:00 +02:00
parent d4ea80ef7c
commit bcbb6e61ef
7 changed files with 60 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/projectwindow.cpp
View File

@@ -554,9 +554,10 @@ public:
for (BuildInfo *info : toImport) {
Target *target = project->target(info->kitId);
if (!target) {
target = project->createTarget(KitManager::kit(info->kitId));
if (target)
project->addTarget(target);
std::unique_ptr<Target> newTarget = project->createTarget(KitManager::kit(info->kitId));
target = newTarget.get();
if (newTarget)
project->addTarget(std::move(newTarget));
}
if (target) {
projectImporter->makePersistent(target->kit());