forked from qt-creator/qt-creator
QmlProfiler: Remove QmlProfilerPlugin::debugOutput
I doubt that anyone has ever used it. Change-Id: Icf8c6513f5cdd10a9aa790e7373df9eba7c12ef2 Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
This commit is contained in:
@@ -97,15 +97,6 @@ void LocalQmlProfilerRunner::start()
|
|||||||
runnable.commandLineArguments = arguments;
|
runnable.commandLineArguments = arguments;
|
||||||
runnable.runMode = ApplicationLauncher::Gui;
|
runnable.runMode = ApplicationLauncher::Gui;
|
||||||
|
|
||||||
if (QmlProfilerPlugin::debugOutput) {
|
|
||||||
QString portOrSocket = m_configuration.socket.isEmpty() ?
|
|
||||||
QString::number(m_configuration.port.isValid() ?
|
|
||||||
m_configuration.port.number() : -1) :
|
|
||||||
m_configuration.socket;
|
|
||||||
qWarning("QmlProfiler: Launching %s:%s", qPrintable(m_configuration.debuggee.executable),
|
|
||||||
qPrintable(portOrSocket));
|
|
||||||
}
|
|
||||||
|
|
||||||
// queue this, as the process can already die in the call to start().
|
// queue this, as the process can already die in the call to start().
|
||||||
// We want the started() signal to be emitted before the stopped() signal.
|
// We want the started() signal to be emitted before the stopped() signal.
|
||||||
connect(&m_launcher, &ApplicationLauncher::processExited,
|
connect(&m_launcher, &ApplicationLauncher::processExited,
|
||||||
@@ -118,13 +109,8 @@ void LocalQmlProfilerRunner::start()
|
|||||||
|
|
||||||
void LocalQmlProfilerRunner::spontaneousStop(int exitCode, QProcess::ExitStatus status)
|
void LocalQmlProfilerRunner::spontaneousStop(int exitCode, QProcess::ExitStatus status)
|
||||||
{
|
{
|
||||||
if (QmlProfilerPlugin::debugOutput) {
|
Q_UNUSED(exitCode);
|
||||||
if (status == QProcess::CrashExit)
|
Q_UNUSED(status);
|
||||||
qWarning("QmlProfiler: Application crashed.");
|
|
||||||
else
|
|
||||||
qWarning("QmlProfiler: Application exited (exit code %d).", exitCode);
|
|
||||||
}
|
|
||||||
|
|
||||||
disconnect(&m_launcher, &ApplicationLauncher::processExited,
|
disconnect(&m_launcher, &ApplicationLauncher::processExited,
|
||||||
this, &LocalQmlProfilerRunner::spontaneousStop);
|
this, &LocalQmlProfilerRunner::spontaneousStop);
|
||||||
|
|
||||||
@@ -133,9 +119,6 @@ void LocalQmlProfilerRunner::spontaneousStop(int exitCode, QProcess::ExitStatus
|
|||||||
|
|
||||||
void LocalQmlProfilerRunner::stop()
|
void LocalQmlProfilerRunner::stop()
|
||||||
{
|
{
|
||||||
if (QmlProfilerPlugin::debugOutput)
|
|
||||||
qWarning("QmlProfiler: Stopping application ...");
|
|
||||||
|
|
||||||
if (m_launcher.isRunning())
|
if (m_launcher.isRunning())
|
||||||
m_launcher.stop();
|
m_launcher.stop();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -317,10 +317,7 @@ void QmlProfilerClientManager::qmlDebugConnectionStateChanged(QAbstractSocket::S
|
|||||||
|
|
||||||
void QmlProfilerClientManager::logState(const QString &msg)
|
void QmlProfilerClientManager::logState(const QString &msg)
|
||||||
{
|
{
|
||||||
QString state = QLatin1String("QML Profiler: ") + msg;
|
QmlProfilerTool::logState(QLatin1String("QML Profiler: ") + msg);
|
||||||
if (QmlProfilerPlugin::debugOutput)
|
|
||||||
qWarning() << state;
|
|
||||||
QmlProfilerTool::logState(state);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void QmlProfilerClientManager::retryMessageBoxFinished(int result)
|
void QmlProfilerClientManager::retryMessageBoxFinished(int result)
|
||||||
|
|||||||
@@ -48,8 +48,6 @@ namespace Internal {
|
|||||||
|
|
||||||
Q_GLOBAL_STATIC(QmlProfilerSettings, qmlProfilerGlobalSettings)
|
Q_GLOBAL_STATIC(QmlProfilerSettings, qmlProfilerGlobalSettings)
|
||||||
|
|
||||||
bool QmlProfilerPlugin::debugOutput = false;
|
|
||||||
|
|
||||||
bool QmlProfilerPlugin::initialize(const QStringList &arguments, QString *errorString)
|
bool QmlProfilerPlugin::initialize(const QStringList &arguments, QString *errorString)
|
||||||
{
|
{
|
||||||
Q_UNUSED(arguments)
|
Q_UNUSED(arguments)
|
||||||
|
|||||||
@@ -44,7 +44,6 @@ public:
|
|||||||
void extensionsInitialized();
|
void extensionsInitialized();
|
||||||
ShutdownFlag aboutToShutdown();
|
ShutdownFlag aboutToShutdown();
|
||||||
|
|
||||||
static bool debugOutput;
|
|
||||||
static QmlProfilerSettings *globalSettings();
|
static QmlProfilerSettings *globalSettings();
|
||||||
|
|
||||||
QList<QObject *> createTestObjects() const override;
|
QList<QObject *> createTestObjects() const override;
|
||||||
|
|||||||
Reference in New Issue
Block a user