QmlProfiler: Remove QmlProfilerPlugin::debugOutput

I doubt that anyone has ever used it.

Change-Id: Icf8c6513f5cdd10a9aa790e7373df9eba7c12ef2
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
This commit is contained in:
Ulf Hermann
2016-06-02 17:25:26 +02:00
parent 16bf9227ba
commit bcbfd93ee7
4 changed files with 3 additions and 26 deletions

View File

@@ -97,15 +97,6 @@ void LocalQmlProfilerRunner::start()
runnable.commandLineArguments = arguments;
runnable.runMode = ApplicationLauncher::Gui;
if (QmlProfilerPlugin::debugOutput) {
QString portOrSocket = m_configuration.socket.isEmpty() ?
QString::number(m_configuration.port.isValid() ?
m_configuration.port.number() : -1) :
m_configuration.socket;
qWarning("QmlProfiler: Launching %s:%s", qPrintable(m_configuration.debuggee.executable),
qPrintable(portOrSocket));
}
// queue this, as the process can already die in the call to start().
// We want the started() signal to be emitted before the stopped() signal.
connect(&m_launcher, &ApplicationLauncher::processExited,
@@ -118,13 +109,8 @@ void LocalQmlProfilerRunner::start()
void LocalQmlProfilerRunner::spontaneousStop(int exitCode, QProcess::ExitStatus status)
{
if (QmlProfilerPlugin::debugOutput) {
if (status == QProcess::CrashExit)
qWarning("QmlProfiler: Application crashed.");
else
qWarning("QmlProfiler: Application exited (exit code %d).", exitCode);
}
Q_UNUSED(exitCode);
Q_UNUSED(status);
disconnect(&m_launcher, &ApplicationLauncher::processExited,
this, &LocalQmlProfilerRunner::spontaneousStop);
@@ -133,9 +119,6 @@ void LocalQmlProfilerRunner::spontaneousStop(int exitCode, QProcess::ExitStatus
void LocalQmlProfilerRunner::stop()
{
if (QmlProfilerPlugin::debugOutput)
qWarning("QmlProfiler: Stopping application ...");
if (m_launcher.isRunning())
m_launcher.stop();
}

View File

@@ -317,10 +317,7 @@ void QmlProfilerClientManager::qmlDebugConnectionStateChanged(QAbstractSocket::S
void QmlProfilerClientManager::logState(const QString &msg)
{
QString state = QLatin1String("QML Profiler: ") + msg;
if (QmlProfilerPlugin::debugOutput)
qWarning() << state;
QmlProfilerTool::logState(state);
QmlProfilerTool::logState(QLatin1String("QML Profiler: ") + msg);
}
void QmlProfilerClientManager::retryMessageBoxFinished(int result)

View File

@@ -48,8 +48,6 @@ namespace Internal {
Q_GLOBAL_STATIC(QmlProfilerSettings, qmlProfilerGlobalSettings)
bool QmlProfilerPlugin::debugOutput = false;
bool QmlProfilerPlugin::initialize(const QStringList &arguments, QString *errorString)
{
Q_UNUSED(arguments)

View File

@@ -44,7 +44,6 @@ public:
void extensionsInitialized();
ShutdownFlag aboutToShutdown();
static bool debugOutput;
static QmlProfilerSettings *globalSettings();
QList<QObject *> createTestObjects() const override;