From bcf879200e66d2eb7883294693198a78762f164c Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Thu, 15 Nov 2018 14:50:43 +0100 Subject: [PATCH] Mercurial: Fix passing editor parameters when creating a factory Otherwise the internal id and and the mimetype members might be just null pointers. Amends 20658d689. Change-Id: I4593d471637c144942130615e5be39c6da85c31f Reviewed-by: Orgad Shaneh --- src/plugins/mercurial/mercurialplugin.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/mercurial/mercurialplugin.cpp b/src/plugins/mercurial/mercurialplugin.cpp index 9e24422d181..6659766352d 100644 --- a/src/plugins/mercurial/mercurialplugin.cpp +++ b/src/plugins/mercurial/mercurialplugin.cpp @@ -133,7 +133,7 @@ bool MercurialPlugin::initialize(const QStringList & /* arguments */, QString * m_client->view(source, id); }; const auto widgetCreator = []() { return new MercurialEditorWidget; }; - for (auto editor : editorParameters) + for (auto &editor : editorParameters) new VcsEditorFactory(&editor, widgetCreator, describeFunc, this); new VcsSubmitEditorFactory(&submitEditorParameters,