feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Ios: Don't call mutable expressions inside QTC_ASSERT

Browse Source 
In order to conform to the theory: "Removing all
QTC_ASSERTs and QTC_CHECKs should not change anything".

Change-Id: Ieed804e44f4ca78a020444eb3f73d64d1bbdc916
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-12-14 12:40:53 +01:00
parent 038847709c
commit bd170f3748
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/ios/iosrunner.cpp
View File

@@ -367,8 +367,9 @@ void IosQmlProfilerSupport::start()
{ {
QUrl serverUrl; QUrl serverUrl;
QTcpServer server; QTcpServer server;
QTC_ASSERT(server.listen(QHostAddress::LocalHost) const bool isListening = server.listen(QHostAddress::LocalHost)
|| server.listen(QHostAddress::LocalHostIPv6), return); || server.listen(QHostAddress::LocalHostIPv6);
QTC_ASSERT(isListening, return);
serverUrl.setScheme(Utils::urlTcpScheme()); serverUrl.setScheme(Utils::urlTcpScheme());
serverUrl.setHost(server.serverAddress().toString()); serverUrl.setHost(server.serverAddress().toString());
@@ -463,8 +464,9 @@ void IosDebugSupport::start()
QUrl qmlServer; QUrl qmlServer;
if (qmlDebug) { if (qmlDebug) {
QTcpServer server; QTcpServer server;
QTC_ASSERT(server.listen(QHostAddress::LocalHost) const bool isListening = server.listen(QHostAddress::LocalHost)
|| server.listen(QHostAddress::LocalHostIPv6), return); || server.listen(QHostAddress::LocalHostIPv6);
QTC_ASSERT(isListening, return);
qmlServer.setHost(server.serverAddress().toString()); qmlServer.setHost(server.serverAddress().toString());
if (!cppDebug) if (!cppDebug)
setStartMode(AttachToRemoteServer); setStartMode(AttachToRemoteServer);