feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Robustify tooltip widget event filter setup

Browse Source 
Amends 5354e7e557.

Change-Id: I0b02c6df8d09d04055bd17dde0754c2a5135b0a5
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
hjk
2024-10-24 14:53:46 +02:00
parent 090b540487
commit bd345efcca
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/debugger/debuggertooltipmanager.cpp
View File

@@ -980,17 +980,23 @@ void DebuggerToolTipManagerPrivate::debugModeEntered()
this, &DebuggerToolTipManagerPrivate::updateVisibleToolTips); this, &DebuggerToolTipManagerPrivate::updateVisibleToolTips);
connect(em, &EditorManager::editorOpened, connect(em, &EditorManager::editorOpened,
this, &DebuggerToolTipManagerPrivate::slotEditorOpened); this, &DebuggerToolTipManagerPrivate::slotEditorOpened);
connect(em, &EditorManager::editorAboutToClose, [this](IEditor *editor) { connect(em, &EditorManager::editorAboutToClose, this, [this](IEditor *editor) {
if (auto textEditor = qobject_cast<BaseTextEditor *>(editor)) if (auto textEditor = qobject_cast<BaseTextEditor *>(editor))
m_tooltips.erase(textEditor->editorWidget()); m_tooltips.erase(textEditor->editorWidget());
}); });
connect(em, &EditorManager::currentEditorAboutToChange, [this](IEditor *editor) { connect(em, &EditorManager::currentEditorAboutToChange, this, [this](IEditor *editor) {
if (auto textEditor = qobject_cast<BaseTextEditor *>(editor)) if (auto textEditor = qobject_cast<BaseTextEditor *>(editor)) {
textEditor->widget()->window()->removeEventFilter(this); QWidget *widget = textEditor->widget();
QTC_ASSERT(widget, return);
widget->removeEventFilter(this);
}
}); });
connect(em, &EditorManager::currentEditorChanged, [this](IEditor *editor) { connect(em, &EditorManager::currentEditorChanged, this, [this](IEditor *editor) {
if (auto textEditor = qobject_cast<BaseTextEditor *>(editor)) if (auto textEditor = qobject_cast<BaseTextEditor *>(editor)) {
textEditor->widget()->window()->installEventFilter(this); QWidget *widget = textEditor->widget();
QTC_ASSERT(widget, return);
widget->window()->installEventFilter(this);
}
}); });
setupEditors(); setupEditors();
} }