feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SettingsAccessor: rename variable

Browse Source 
Change-Id: I78c41f89a6da05b340790ee7feeb976a327e2a4a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Tobias Hunger
2013-04-04 13:18:56 +02:00
parent e262596dc4
commit bd5e8b3f7c
1 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/plugins/projectexplorer/settingsaccessor.cpp
View File

@@ -595,16 +595,16 @@ QVariantMap SettingsAccessor::restoreSettings() const
if (m_lastVersion < 0) if (m_lastVersion < 0)
return QVariantMap(); return QVariantMap();
SettingsData settings; SettingsData userSettings;
QString fn = project()->property(m_userFileAcessor.id()).toString(); QString fn = project()->property(m_userFileAcessor.id()).toString();
if (fn.isEmpty()) if (fn.isEmpty())
fn = project()->document()->fileName() + m_userFileAcessor.suffix(); fn = project()->document()->fileName() + m_userFileAcessor.suffix();
settings.m_fileName = Utils::FileName::fromString(fn); userSettings.m_fileName = Utils::FileName::fromString(fn);
if (!m_userFileAcessor.readFile(&settings)) if (!m_userFileAcessor.readFile(&userSettings))
settings.clear(); // No user settings, but there can still be shared ones. userSettings.clear(); // No user settings, but there can still be shared ones.
if (settings.isValid()) { if (userSettings.isValid()) {
if (settings.m_version > m_lastVersion + 1) { if (userSettings.m_version > m_lastVersion + 1) {
QMessageBox::information( QMessageBox::information(
Core::ICore::mainWindow(), Core::ICore::mainWindow(),
QApplication::translate("ProjectExplorer::SettingsAccessor", QApplication::translate("ProjectExplorer::SettingsAccessor",
@@ -622,7 +622,7 @@ QVariantMap SettingsAccessor::restoreSettings() const
} }
// Verify environment. // Verify environment.
const QByteArray fileId = settings.environmentId(); const QByteArray fileId = userSettings.environmentId();
const QByteArray creatorId = ProjectExplorerPlugin::instance()->projectExplorerSettings().environmentId.toByteArray(); const QByteArray creatorId = ProjectExplorerPlugin::instance()->projectExplorerSettings().environmentId.toByteArray();
if (fileId.isEmpty() || fileId != creatorId) { if (fileId.isEmpty() || fileId != creatorId) {
QString backup = fn + QLatin1Char('.') + QString::fromLatin1(fileId).mid(1, 7); QString backup = fn + QLatin1Char('.') + QString::fromLatin1(fileId).mid(1, 7);
@@ -652,12 +652,12 @@ QVariantMap SettingsAccessor::restoreSettings() const
} }
// Do we need to generate a backup? // Do we need to generate a backup?
if (settings.m_version < m_lastVersion + 1 && !settings.m_usingBackup) { if (userSettings.m_version < m_lastVersion + 1 && !userSettings.m_usingBackup) {
const QString &backupFileName = settings.m_fileName.toString() const QString &backupFileName = userSettings.m_fileName.toString()
+ QLatin1Char('.') + QLatin1Char('.')
+ m_handlers.value(settings.m_version)->displayUserFileVersion(); + m_handlers.value(userSettings.m_version)->displayUserFileVersion();
QFile::remove(backupFileName); // Remove because copy doesn't overwrite QFile::remove(backupFileName); // Remove because copy doesn't overwrite
QFile::copy(settings.m_fileName.toString(), backupFileName); QFile::copy(userSettings.m_fileName.toString(), backupFileName);
} }
} }
@@ -670,7 +670,7 @@ QVariantMap SettingsAccessor::restoreSettings() const
sharedSettings.m_fileName = Utils::FileName::fromString(fn); sharedSettings.m_fileName = Utils::FileName::fromString(fn);
if (!sharedSettings.m_fileName.isEmpty() && m_sharedFileAcessor.readFile(&sharedSettings)) { if (!sharedSettings.m_fileName.isEmpty() && m_sharedFileAcessor.readFile(&sharedSettings)) {
bool useSharedSettings = true; bool useSharedSettings = true;
if (sharedSettings.m_version != settings.m_version) { if (sharedSettings.m_version != userSettings.m_version) {
int baseFileVersion; int baseFileVersion;
if (sharedSettings.m_version > m_lastVersion + 1) { if (sharedSettings.m_version > m_lastVersion + 1) {
// The shared file version is newer than Creator... If we have valid user // The shared file version is newer than Creator... If we have valid user
@@ -678,7 +678,7 @@ QVariantMap SettingsAccessor::restoreSettings() const
// This makes sense since the merging operation will only replace shared settings // This makes sense since the merging operation will only replace shared settings
// that perfectly match corresponding user ones. If we don't have valid user // that perfectly match corresponding user ones. If we don't have valid user
// settings to compare against, there's nothing we can do. // settings to compare against, there's nothing we can do.
if (!settings.isValid()) if (!userSettings.isValid())
return QVariantMap(); return QVariantMap();
QMessageBox msgBox( QMessageBox msgBox(
@@ -700,7 +700,7 @@ QVariantMap SettingsAccessor::restoreSettings() const
else else
baseFileVersion = m_lastVersion + 1; baseFileVersion = m_lastVersion + 1;
} else { } else {
baseFileVersion = qMax(settings.m_version, sharedSettings.m_version); baseFileVersion = qMax(userSettings.m_version, sharedSettings.m_version);
} }
if (useSharedSettings) { if (useSharedSettings) {
@@ -708,31 +708,31 @@ QVariantMap SettingsAccessor::restoreSettings() const
for (int i = sharedSettings.m_version; i < baseFileVersion; ++i) for (int i = sharedSettings.m_version; i < baseFileVersion; ++i)
sharedSettings.m_map = m_handlers.value(i)->update(m_project, sharedSettings.m_map); sharedSettings.m_map = m_handlers.value(i)->update(m_project, sharedSettings.m_map);
if (settings.isValid()) { if (userSettings.isValid()) {
for (int i = settings.m_version; i < baseFileVersion; ++i) for (int i = userSettings.m_version; i < baseFileVersion; ++i)
settings.m_map = m_handlers.value(i)->update(m_project, settings.m_map); userSettings.m_map = m_handlers.value(i)->update(m_project, userSettings.m_map);
settings.m_version = baseFileVersion; userSettings.m_version = baseFileVersion;
} }
} }
} }
if (useSharedSettings) { if (useSharedSettings) {
m_project->setProperty(SHARED_SETTINGS, sharedSettings.m_map); m_project->setProperty(SHARED_SETTINGS, sharedSettings.m_map);
if (settings.isValid()) if (userSettings.isValid())
mergeSharedSettings(&settings.m_map, sharedSettings.m_map); mergeSharedSettings(&userSettings.m_map, sharedSettings.m_map);
if (!settings.isValid()) if (!userSettings.isValid())
settings = sharedSettings; userSettings = sharedSettings;
} }
} }
if (!settings.isValid()) if (!userSettings.isValid())
return QVariantMap(); return QVariantMap();
// Update from the base version to Creator's version. // Update from the base version to Creator's version.
for (int i = settings.m_version; i <= m_lastVersion; ++i) for (int i = userSettings.m_version; i <= m_lastVersion; ++i)
settings.m_map = m_handlers.value(i)->update(m_project, settings.m_map); userSettings.m_map = m_handlers.value(i)->update(m_project, userSettings.m_map);
return settings.m_map; return userSettings.m_map;
} }
bool SettingsAccessor::saveSettings(const QVariantMap &map) const bool SettingsAccessor::saveSettings(const QVariantMap &map) const