From bd9c2f04c00dfb6b80a28c70281f618f9650c0d9 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Fri, 16 Nov 2018 09:21:25 +0100 Subject: [PATCH] TextEditor: fix crash on setting text cursor Setting a text cursor with a currently open edit block results in crashes. Fixes: QTCREATORBUG-21471 Change-Id: I267cdaf10b20959654c2923e5dcc0a07793f3094 Reviewed-by: Christian Stenger --- src/plugins/texteditor/texteditor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/texteditor/texteditor.cpp b/src/plugins/texteditor/texteditor.cpp index 3ae7a79751c..9f8fed1122f 100644 --- a/src/plugins/texteditor/texteditor.cpp +++ b/src/plugins/texteditor/texteditor.cpp @@ -2492,9 +2492,9 @@ void TextEditorWidget::keyPressEvent(QKeyEvent *e) d->autocompleterHighlight(tc); } } + cursor.endEditBlock(); setTextCursor(ensureVisible); cursor.setPosition(cursorPosition); - cursor.endEditBlock(); } setTextCursor(cursor);