feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

MinimizableInfoBars: Move constants from global to local

Browse Source 
Change-Id: I7728ba8a81724d60797758e7b50e71ed1a22750c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Eike Ziller
2022-05-02 17:39:35 +02:00
parent 4aa1690a9b
commit bd9ecfc41a
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/cppeditor/cppeditorconstants.h
View File

@@ -38,7 +38,6 @@ const char SWITCH_DECLARATION_DEFINITION[] = "CppEditor.SwitchDeclarationDefinit
const char OPEN_DECLARATION_DEFINITION_IN_NEXT_SPLIT[] = "CppEditor.OpenDeclarationDefinitionInNextSplit";
const char OPEN_PREPROCESSOR_DIALOG[] = "CppEditor.OpenPreprocessorDialog";
const char MULTIPLE_PARSE_CONTEXTS_AVAILABLE[] = "CppEditor.MultipleParseContextsAvailable";
const char NO_PROJECT_CONFIGURATION[] = "CppEditor.NoProjectConfiguration";
const char M_REFACTORING_MENU_INSERTION_POINT[] = "CppEditor.RefactorGroup";
const char UPDATE_CODEMODEL[] = "CppEditor.UpdateCodeModel";
const char INSPECT_CPP_CODEMODEL[] = "CppEditor.InspectCppCodeModel";

8
src/plugins/cppeditor/cppminimizableinfobars.cpp
View File

@@ -25,7 +25,6 @@
#include "cppminimizableinfobars.h"
#include "cppeditorconstants.h"
#include "cpptoolssettings.h"
#include <QToolButton>
@@ -34,6 +33,8 @@
#include <utils/qtcassert.h>
#include <utils/utilsicons.h>
const char NO_PROJECT_CONFIGURATION[] = "CppEditor.NoProjectConfiguration";
using namespace Utils;
namespace CppEditor {
@@ -57,8 +58,7 @@ void MinimizableInfoBars::createActions()
action->setIcon(Icons::WARNING_TOOLBAR.pixmap());
connect(action, &QAction::triggered, []() { settings()->setShowNoProjectInfoBar(true); });
action->setVisible(!settings()->showNoProjectInfoBar());
m_actions.insert(Constants::NO_PROJECT_CONFIGURATION, action);
m_actions.insert(NO_PROJECT_CONFIGURATION, action);
}
void MinimizableInfoBars::createShowInfoBarActions(const ActionCreator &actionCreator) const
@@ -84,7 +84,7 @@ void MinimizableInfoBars::processHasProjectPart(bool hasProjectPart)
void MinimizableInfoBars::updateNoProjectConfiguration()
{
const Id id(Constants::NO_PROJECT_CONFIGURATION);
const Id id(NO_PROJECT_CONFIGURATION);
m_infoBar.removeInfo(id);
bool show = false;