feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: use argumentCount in loops in initializer.

Browse Source 
argumentCount is a more expensive function, so try to call it only once,
esp. in loops.

Change-Id: I6f0d420352743ec444487ce3f506ef28e5282d1e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
This commit is contained in:
Erik Verbruggen
2013-03-13 12:51:58 +01:00
parent fb28c14541
commit bdb5142102
9 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cppeditor/cppfunctiondecldeflink.cpp
View File

@@ -381,10 +381,10 @@ void FunctionDeclDefLink::showMarker(CPPEditorWidget *editor)
// does consider foo(void) to have one argument
static int declaredParameterCount(Function *function)
{
int c = function->argumentCount();
if (c == 0 && function->memberCount() > 0 && function->memberAt(0)->type().type()->isVoidType())
int argc = function->argumentCount();
if (argc == 0 && function->memberCount() > 0 && function->memberAt(0)->type().type()->isVoidType())
return 1;
return c;
return argc;
}
Q_GLOBAL_STATIC(QRegExp, commentArgNameRegexp)