From be2c138dcc09494b18f42936e2a904a56b81e0cf Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 7 Jan 2025 15:11:16 +0100 Subject: [PATCH] TaskTree: Define parentTask a bit earlier Change-Id: I4cb68e073e7d56f8d739b4b1cb387594b7e6a9f2 Reviewed-by: hjk --- src/libs/solutions/tasking/tasktree.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libs/solutions/tasking/tasktree.cpp b/src/libs/solutions/tasking/tasktree.cpp index 5218690dc4b..bda72e8501f 100644 --- a/src/libs/solutions/tasking/tasktree.cpp +++ b/src/libs/solutions/tasking/tasktree.cpp @@ -2200,17 +2200,17 @@ void RuntimeContainer::deleteFinishedIterations() void TaskTreePrivate::continueContainer(RuntimeContainer *container) { - if (container->m_parentTask->m_setupResult == SetupResult::Continue) + RuntimeTask *parentTask = container->m_parentTask; + if (parentTask->m_setupResult == SetupResult::Continue) startChildren(container); - if (container->m_parentTask->m_setupResult == SetupResult::Continue) + if (parentTask->m_setupResult == SetupResult::Continue) return; - const bool bit = container->updateSuccessBit(container->m_parentTask->m_setupResult == SetupResult::StopWithSuccess); + const bool bit = container->updateSuccessBit(parentTask->m_setupResult == SetupResult::StopWithSuccess); RuntimeIteration *parentIteration = container->parentIteration(); - RuntimeTask *parentTask = container->m_parentTask; QT_CHECK(parentTask); const bool result = invokeDoneHandler(container, bit ? DoneWith::Success : DoneWith::Error); - container->m_parentTask->m_setupResult = toSetupResult(result); + parentTask->m_setupResult = toSetupResult(result); if (parentIteration) { parentIteration->removeChild(parentTask); if (!parentIteration->m_container->isStarting())