From be3dd751cbac7c9de26cb8190a1766db203ee97a Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 29 Sep 2021 16:35:52 +0200 Subject: [PATCH] ClangCodeModel: Replace FIXME comments with links to bug reports Change-Id: Ib6520781e88b8dcf63dd553e199939ff65ae1f05 Reviewed-by: David Schulz --- src/plugins/clangcodemodel/test/clangdtests.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/plugins/clangcodemodel/test/clangdtests.cpp b/src/plugins/clangcodemodel/test/clangdtests.cpp index c71bd2d3644..7829cb0b74d 100644 --- a/src/plugins/clangcodemodel/test/clangdtests.cpp +++ b/src/plugins/clangcodemodel/test/clangdtests.cpp @@ -1627,7 +1627,7 @@ void ClangdTestCompletion::testFunctionHintsFiltered() QVERIFY(proposal); QCOMPARE(proposal->size(), 2); QVERIFY(hasItem(proposal, "func(const S &s, int j) -> void")); - QEXPECT_FAIL("", "FIXME: LanguageClient handles active parameter only in active signature", Abort); + QEXPECT_FAIL("", "QTCREATORBUG-26346", Abort); QVERIFY(hasItem(proposal, "func(const S &s, int j, int k) -> void")); } @@ -1640,7 +1640,7 @@ void ClangdTestCompletion::testFunctionHintConstructor() QVERIFY(!hasItem(proposal, "globalVariable")); QVERIFY(!hasItem(proposal, " class")); QVERIFY(hasItem(proposal, "Foo(int)")); - QEXPECT_FAIL("", "FIXME: LanguageClient handles active parameter only in active signature", Abort); + QEXPECT_FAIL("", "QTCREATORBUG-26346", Abort); QVERIFY(hasItem(proposal, "Foo(int, double)")); } @@ -1669,8 +1669,7 @@ void ClangdTestCompletion::testCompletePrivateFunctionDefinition() getProposal("privateFuncDefCompletion.cpp", proposal); QVERIFY(proposal); - QEXPECT_FAIL("", "FIXME: clangd needs to differentiate " - "between function call and function definiton", Abort); + QEXPECT_FAIL("", "https://github.com/clangd/clangd/issues/880", Abort); QCOMPARE(proposal->size(), 1); QVERIFY(hasItem(proposal, " theFunc()")); }