feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TarPackageInstaller: Connect to done() signal instead of finished()

Browse Source 
This should also handle a failed to start case.

Change-Id: I1f85873834c316263d132e357e23654a4bb7777f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-06-20 16:49:21 +02:00
parent a613caa234
commit be5a77a767
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/remotelinux/tarpackagedeploystep.cpp
View File

@@ -77,7 +77,7 @@ TarPackageInstaller::TarPackageInstaller()
connect(&m_installer, &QtcProcess::readyReadStandardError, this, [this] { connect(&m_installer, &QtcProcess::readyReadStandardError, this, [this] {
emit stderrData(QString::fromUtf8(m_installer.readAllStandardError())); emit stderrData(QString::fromUtf8(m_installer.readAllStandardError()));
}); });
connect(&m_installer, &QtcProcess::finished, this, [this] { connect(&m_installer, &QtcProcess::done, this, [this] {
const QString errorMessage = m_installer.result() == ProcessResult::FinishedWithSuccess const QString errorMessage = m_installer.result() == ProcessResult::FinishedWithSuccess
? QString() : tr("Installing package failed.") + m_installer.errorString(); ? QString() : tr("Installing package failed.") + m_installer.errorString();
emit finished(errorMessage); emit finished(errorMessage);