From be6ea67bfdd026046cb3bf1bb95251054f9f3506 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Fri, 24 Sep 2021 14:10:30 +0200 Subject: [PATCH] ClangCodeModel: Replace TODO items with links to upstream bug reports Change-Id: Iff1ccf77aca74bc34e2944996e7ef2eb2fcb3bad Reviewed-by: David Schulz --- src/plugins/clangcodemodel/clangdclient.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/clangcodemodel/clangdclient.cpp b/src/plugins/clangcodemodel/clangdclient.cpp index e9212b3d765..982052dcb9a 100644 --- a/src/plugins/clangcodemodel/clangdclient.cpp +++ b/src/plugins/clangcodemodel/clangdclient.cpp @@ -2187,7 +2187,7 @@ static void collectExtraResults(QFutureInterface // the closing angle brackets, then the inner TemplateSpecialization node's range // will extend one character too far, covering the outer's closing angle bracket. // This is what we are correcting for here. - // TODO: Can we fix this in clang? + // This issue is tracked at https://github.com/clangd/clangd/issues/871. if (searchStart2 == searchEnd2) --searchStart2; insertAngleBracketInfo(nodeStartPos, posForNodeStart(children.at(1)), @@ -2451,8 +2451,8 @@ static void semanticHighlighter(QFutureInterface const AstNode node = path.at(path.length() - 2); if (node.kind() == "CXXDestructor" && !node.arcanaContains("implicit")) { styles.mainStyle = TextEditor::C_FUNCTION; - // TODO: "declaration" modifier is missing for destructors; fix in clangd - // (the scope is also wrong) + + // https://github.com/clangd/clangd/issues/872 if (node.role() == "declaration") styles.mixinStyles.push_back(TextEditor::C_DECLARATION); }