feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fixed crash when trying to copy large binary file

Browse Source 
Reviewed-by: Oswald Buddenhagen
Task-number: QTCREATORBUG-484
This commit is contained in:
Robert Loehning
2010-03-08 20:19:33 +01:00
parent 2f84e65b8f
commit bec01778d9
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/bineditor/bineditor.cpp
View File

@@ -41,6 +41,7 @@
#include <QtGui/QClipboard> #include <QtGui/QClipboard>
#include <QtGui/QFontMetrics> #include <QtGui/QFontMetrics>
#include <QtGui/QMenu> #include <QtGui/QMenu>
#include <QtGui/QMessageBox>
#include <QtGui/QPainter> #include <QtGui/QPainter>
#include <QtGui/QScrollBar> #include <QtGui/QScrollBar>
#include <QtGui/QWheelEvent> #include <QtGui/QWheelEvent>
@@ -1124,7 +1125,13 @@ void BinEditor::copy(bool raw)
const int selStart = selectionStart(); const int selStart = selectionStart();
const int selEnd = selectionEnd(); const int selEnd = selectionEnd();
if (selStart < selEnd) { if (selStart < selEnd) {
const QByteArray &data = dataMid(selStart, selEnd - selStart); const int selectionLength = selEnd - selStart;
if (selectionLength >> 22) {
QMessageBox::warning(this, tr("Copying Failed"),
tr("You cannot copy more than 4 MB of binary data."));
return;
}
const QByteArray &data = dataMid(selStart, selectionLength);
if (raw) { if (raw) {
QApplication::clipboard()->setText(data); QApplication::clipboard()->setText(data);
return; return;