From beed0c7396979ecdddc6fdd014841e4aabf0935d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 5 Feb 2020 14:54:26 +0100 Subject: [PATCH] CMake/Qbs: Do not emit Project::fileListChanged() ...explicitly. This is already done as part of Project::setRootProjectNode(), and the signal is connected to some rather expensive operations. Task-number: QTCREATORBUG-18533 Change-Id: I96ea2f49c866f2b60f599748c4d5b82c790ed2ca Reviewed-by: hjk --- src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp | 2 -- src/plugins/qbsprojectmanager/qbsproject.cpp | 1 - 2 files changed, 3 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp index 0ab7ff8e62c..d33c5f48ac9 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp @@ -481,8 +481,6 @@ void CMakeBuildSystem::updateProjectData() updateQmlJSCodeModel(); } - emit p->fileListChanged(); - emit m_buildConfiguration->emitBuildTypeChanged(); m_buildDirManager.resetData(); diff --git a/src/plugins/qbsprojectmanager/qbsproject.cpp b/src/plugins/qbsprojectmanager/qbsproject.cpp index f5b2538dc87..b915107202a 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.cpp +++ b/src/plugins/qbsprojectmanager/qbsproject.cpp @@ -463,7 +463,6 @@ void QbsBuildSystem::updateAfterParse() updateCppCodeModel(); updateExtraCompilers(); updateQmlJsCodeModel(); - emit project()->fileListChanged(); m_envCache.clear(); m_guard.markAsSuccess(); m_guard = {};