feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Move OpenPagesManager::createPage to HelpWidget

Browse Source 
Removes some unneeded indirection.

Task-number: QTCREATORBUG-20558
Change-Id: I65d8d31e10300da3015f388ac490b8be6e090f29
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2019-09-11 15:34:42 +02:00
parent bd228ab6dd
commit bef986f3fd
5 changed files with 16 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/help/openpagesmanager.cpp
View File

@@ -173,22 +173,6 @@ void OpenPagesManager::setupInitialPages()
m_helpWidget->setCurrentIndex(std::max(initialPage, m_helpWidget->viewerCount() - 1));
}
HelpViewer *OpenPagesManager::createPage()
{
return createPage(QUrl(Help::Constants::AboutBlank));
}
HelpViewer *OpenPagesManager::createPage(const QUrl &url)
{
if (url.isValid() && HelpViewer::launchWithExternalApp(url))
return nullptr;
HelpViewer *page = m_helpWidget->addViewer(url);
m_helpWidget->setCurrentIndex(m_helpWidget->viewerCount() - 1);
return page;
}
void OpenPagesManager::closeCurrentPage()
{
if (!m_openPagesWidget)