feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Do not pass QStringView by const reference

Browse Source 
That's what the documentation says:

  https://doc.qt.io/qt-6/qstringview.html#details

Change-Id: I0b41fc4abad1601c0ed416a505534cf7ae7633e1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Kai Köhne
2021-06-15 20:25:49 +02:00
committed by Kai Koehne
parent 4bfcea22bf
commit bf04c98c1c
22 changed files with 68 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmljseditor/qmljseditor.cpp
View File

@@ -417,7 +417,7 @@ protected:
{
UiQualifiedId *id = qualifiedTypeNameId(member);
if (id) {
const QStringView &name = id->name;
QStringView name = id->name;
if (!name.isEmpty() && name.at(0).isUpper())
return true;
}
@@ -435,7 +435,7 @@ protected:
else if (script->qualifiedId->next)
return false;
const QStringView &propertyName = script->qualifiedId->name;
QStringView propertyName = script->qualifiedId->name;
if (propertyName == QLatin1String("id"))
return true;