feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fixes for valgrind-callgrind feedback by Nokia

Browse Source 
Most changes include style fixes and UI changes for better usability.

Merge-request: 324
Reviewed-by: hjk <qtc-committer@nokia.com>
This commit is contained in:
Kevin Funk
2011-05-11 16:26:34 +02:00
committed by hjk
parent f5601d7b1b
commit bf1f5c2b02
44 changed files with 429 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/memcheck/memcheckerrorview.cpp
View File

@@ -176,7 +176,7 @@ QString errorLocation(const QModelIndex &index, const Error &error,
{
const ErrorListModel *model = 0;
const QAbstractProxyModel *proxy = qobject_cast<const QAbstractProxyModel *>(index.model());
while(!model && proxy) {
while (!model && proxy) {
model = qobject_cast<const ErrorListModel *>(proxy->sourceModel());
proxy = qobject_cast<const QAbstractProxyModel *>(proxy->sourceModel());
};
@@ -393,12 +393,12 @@ void MemcheckErrorDelegate::copy()
const QString relativeTo = relativeToPath();
foreach(const Stack &stack, error.stacks()) {
foreach (const Stack &stack, error.stacks()) {
if (!stack.auxWhat().isEmpty()) {
stream << stack.auxWhat();
}
int i = 1;
foreach(const Frame &frame, stack.frames()) {
foreach (const Frame &frame, stack.frames()) {
stream << " " << i++ << ": " << makeFrameName(frame, relativeTo) << "\n";
}
}
@@ -488,7 +488,7 @@ void MemcheckErrorView::contextMenuEvent(QContextMenuEvent *e)
QList<Error> errors;
foreach(const QModelIndex &index, indizes) {
foreach (const QModelIndex &index, indizes) {
Error error = model()->data(index, ErrorListModel::ErrorRole).value<Error>();
if (!error.suppression().isNull())
errors << error;