ClangCodeModel: Make use of QLoggingCategory

Change-Id: I28d50e224803096c032ae6e387bf1346db4cc216
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

src/plugins/clangcodemodel/clangcompletion.cpp

@@ -61,11 +61,10 @@
 
 #include <QCoreApplication>
 #include <QDirIterator>
+#include <QLoggingCategory>
 #include <QTextCursor>
 #include <QTextDocument>
 
-static const bool DebugTiming = qgetenv("QTC_CLANG_VERBOSE") == "1";
-
 using namespace ClangCodeModel;
 using namespace ClangCodeModel::Internal;
 using namespace CPlusPlus;
@@ -73,6 +72,7 @@ using namespace CppTools;
 using namespace TextEditor;
 
 static const char SNIPPET_ICON_PATH[] = ":/texteditor/images/snippet.png";
+static Q_LOGGING_CATEGORY(log, "qtc.clangcodemodel.completion")
 
 namespace {
 
@@ -170,17 +170,13 @@ static QList<CodeCompletionResult> unfilteredCompletion(const ClangCompletionAss
     if (!modifiedInput.isEmpty())
         unsavedFiles.insert(fileName, modifiedInput);
 
-    QTime t;
+    qCDebug(log) << "Starting completion...";
-    if (DebugTiming) {
+    QTime t; t.start();
-        qDebug() << "Here we go with ClangCompletionAssistProcessor....";
-        t.start();
-    }
 
     QList<CodeCompletionResult> result = wrapper->codeCompleteAt(line, column + 1, unsavedFiles);
     ::Utils::sort(result);
 
-    if (DebugTiming)
+    qCDebug(log) << "Completion done in" << t.elapsed() << "ms, with" << result.count() << "items.";
-        qDebug() << "... Completion done in" << t.elapsed() << "ms, with" << result.count() << "items.";
 
     return result;
 }
@@ -977,8 +973,7 @@ int ClangCompletionAssistProcessor::startCompletionInternal(const QString fileNa
         int l = line, c = column;
         Convenience::convertPosition(m_interface->textDocument(), nameStart, &l, &c);
 
-        if (DebugTiming)
+        qCDebug(log)<<"complete constructor or function @" << line<<":"<<column << "->"<<l<<":"<<c;
-            qDebug()<<"complete constructor or function @" << line<<":"<<column << "->"<<l<<":"<<c;
 
         const QList<CodeCompletionResult> completions = unfilteredCompletion(
                     m_interface.data(), fileName, l, c, QByteArray(), signalCompletion || slotCompletion);

src/plugins/clangcodemodel/clangeditordocumentparser.cpp

@@ -40,7 +40,9 @@
 #include <utils/hostosinfo.h>
 #include <utils/qtcassert.h>
 
-static const bool DebugTiming = qgetenv("QTC_CLANG_VERBOSE") == "1";
+#include <QLoggingCategory>
+
+static Q_LOGGING_CATEGORY(log, "qtc.clangcodemodel.clangeditordocumentparser")
 
 namespace {
 
@@ -91,20 +93,16 @@ void ClangEditorDocumentParser::update(CppTools::WorkingCopy workingCopy)
     updateProjectPart();
     const QStringList options = createOptions(filePath(), projectPart());
 
-    QTime t;
+    qCDebug(log, "Reparse options (cmd line equivalent): %s",
-    if (DebugTiming) {
+           commandLine(options, filePath()).toUtf8().constData());
-        qDebug("*** Reparse options (cmd line equivalent): %s",
+    QTime t; t.start();
-               commandLine(options, filePath()).toUtf8().constData());
-        t.start();
-    }
 
     m_marker->setFileName(filePath());
     m_marker->setCompilationOptions(options);
     const Internal::UnsavedFiles unsavedFiles = Utils::createUnsavedFiles(workingCopy);
     m_marker->reparse(unsavedFiles);
 
-    if (DebugTiming)
+    qCDebug(log) << "Reparse took" << t.elapsed() << "ms.";
-        qDebug() << "*** Reparse took" << t.elapsed() << "ms.";
 }
 
 QList<Diagnostic> ClangEditorDocumentParser::diagnostics() const

src/plugins/clangcodemodel/clangeditordocumentprocessor.cpp

@@ -42,7 +42,9 @@
 #include <utils/qtcassert.h>
 #include <utils/QtConcurrentTools>
 
-static const bool DebugTiming = qgetenv("QTC_CLANG_VERBOSE") == "1";
+#include <QLoggingCategory>
+
+static Q_LOGGING_CATEGORY(log, "qtc.clangcodemodel.clangeditordocumentprocessor")
 
 namespace {
 
@@ -55,8 +57,7 @@ QList<CppToolsDiagnostic> toCppToolsDiagnostics(
 
     QList<CppToolsDiagnostic> converted;
     foreach (const ClangCodeModel::Diagnostic &d, diagnostics) {
-        if (DebugTiming)
+        qCDebug(log) << "diagnostic" << d.severityAsString() << d.location() << d.spelling();
-            qDebug() << d.severityAsString() << d.location() << d.spelling();
 
         if (d.location().fileName() != filePath)
             continue;

src/plugins/clangcodemodel/clangutils.cpp

@@ -41,6 +41,7 @@
 
 #include <QDir>
 #include <QFile>
+#include <QLoggingCategory>
 #include <QSet>
 #include <QString>
 
@@ -49,11 +50,11 @@ using namespace ClangCodeModel::Internal;
 using namespace Core;
 using namespace CppTools;
 
-static const bool BeVerbose = qgetenv("QTC_CLANG_VERBOSE") == "1";
-
 namespace ClangCodeModel {
 namespace Utils {
 
+Q_LOGGING_CATEGORY(verboseRunLog, "qtc.clangcodemodel.verboserun")
+
 namespace {
 bool isBlacklisted(const QString &path)
 {
@@ -139,7 +140,7 @@ QStringList createClangOptions(const ProjectPart::Ptr &pPart, ProjectFile::Kind
     if (pPart.isNull())
         return result;
 
-    if (BeVerbose)
+    if (verboseRunLog().isDebugEnabled())
         result << QLatin1String("-v");
 
     const bool objcExt = pPart->languageExtensions & ProjectPart::ObjectiveCExtensions;

src/plugins/clangcodemodel/clangutils.h

@@ -36,9 +36,13 @@
 
 #include <cpptools/cppmodelmanager.h>
 
+#include <QLoggingCategory>
+
 namespace ClangCodeModel {
 namespace Utils {
 
+Q_DECLARE_LOGGING_CATEGORY(verboseRunLog)
+
 ClangCodeModel::Internal::UnsavedFiles createUnsavedFiles(CppTools::WorkingCopy workingCopy);
 
 QStringList createClangOptions(const CppTools::ProjectPart::Ptr &pPart,

src/plugins/clangcodemodel/cppcreatemarkers.cpp

@@ -35,17 +35,18 @@
 #include <utils/runextensions.h>
 
 #include <QCoreApplication>
+#include <QLoggingCategory>
 #include <QMutexLocker>
 #include <QThreadPool>
 
 #include <QDebug>
 
-static const bool DebugTiming = qgetenv("QTC_CLANG_VERBOSE") == "1";
-
 using namespace ClangCodeModel;
 using namespace ClangCodeModel::Internal;
 using namespace CppTools;
 
+static Q_LOGGING_CATEGORY(log, "qtc.clangcodemodel.createmarkers")
+
 CreateMarkers *CreateMarkers::create(SemanticMarker::Ptr semanticMarker,
                                      const QString &fileName,
                                      unsigned firstLine, unsigned lastLine)
@@ -79,11 +80,9 @@ void CreateMarkers::run()
     if (isCanceled())
         return;
 
-    QTime t;
+    qCDebug(log) << "Creating markers from" << m_firstLine << "to" << m_lastLine
-    if (DebugTiming) {
+                 << "of" << m_fileName;
-        qDebug() << "*** Highlighting from" << m_firstLine << "to" << m_lastLine << "of" << m_fileName;
+    QTime t; t.start();
-        t.start();
-    }
 
     m_usages.clear();
 
@@ -105,10 +104,7 @@ void CreateMarkers::run()
     flush();
     reportFinished();
 
-    if (DebugTiming) {
+    qCDebug(log) << "Creating markers took" << t.elapsed() << "ms in total.";
-        qDebug() << "*** Highlighting took" << t.elapsed() << "ms in total.";
-        t.restart();
-    }
 }
 
 void CreateMarkers::addUse(const SourceMarker &marker)

src/plugins/clangcodemodel/unit.cpp

@@ -29,6 +29,8 @@
 ****************************************************************************/
 
 #include "unit.h"
+
+#include "clangutils.h"
 #include "unsavedfiledata.h"
 #include "utils_p.h"
 
@@ -47,8 +49,6 @@ static QBasicAtomicInt unitDataCount = Q_BASIC_ATOMIC_INITIALIZER(0);
 using namespace ClangCodeModel;
 using namespace ClangCodeModel::Internal;
 
-static const int DisplayDiagnostics = (qgetenv("QTC_CLANG_VERBOSE") == "1") ? 1 : 0;
-
 Unit::Unit()
     : m_index(0)
     , m_tu(0)
@@ -56,7 +56,7 @@ Unit::Unit()
 {}
 
 Unit::Unit(const QString &fileName)
-    : m_index(clang_createIndex(/*excludeDeclsFromPCH*/ 1, DisplayDiagnostics))
+    : m_index(clang_createIndex(/*excludeDeclsFromPCH*/ 1, Utils::verboseRunLog().isDebugEnabled()))
     , m_tu(0)
     , m_fileName(fileName.toUtf8())
     , m_managementOptions(0)