feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix Clang warnings

Browse Source 
Do not hide virtual done() slot with done() signal.

Change-Id: Ic09439fdac2727f316f4a0983ffbd290f8555292
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Thomas Hartmann
2016-02-24 11:49:54 +01:00
parent d3c44bd319
commit bf9777e7c6
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/componentcore/addsignalhandlerdialog.cpp
View File

@@ -74,5 +74,5 @@ void AddSignalHandlerDialog::updateComboBox()
void AddSignalHandlerDialog::handleAccepted() void AddSignalHandlerDialog::handleAccepted()
{ {
m_signal = m_ui->comboBox->currentText(); m_signal = m_ui->comboBox->currentText();
emit done(); emit signalSelected();
} }

2
src/plugins/qmldesigner/components/componentcore/addsignalhandlerdialog.h
View File

@@ -43,7 +43,7 @@ public:
QString signal() const; QString signal() const;
signals: signals:
void done(); void signalSelected();
private: private:
void updateComboBox(); void updateComboBox();

2
src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp
View File

@@ -695,7 +695,7 @@ void gotoImplementation(const SelectionContext &selectionState)
AddSignalHandlerDialog *dialog = new AddSignalHandlerDialog(Core::ICore::dialogParent()); AddSignalHandlerDialog *dialog = new AddSignalHandlerDialog(Core::ICore::dialogParent());
dialog->setSignals(signalNames); dialog->setSignals(signalNames);
AddSignalHandlerDialog::connect(dialog, &AddSignalHandlerDialog::done, [=] { AddSignalHandlerDialog::connect(dialog, &AddSignalHandlerDialog::signalSelected, [=] {
dialog->deleteLater(); dialog->deleteLater();
if (dialog->signal().isEmpty()) if (dialog->signal().isEmpty())