feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Use QtcProcess::stop instead of stopProcess

Browse Source 
Less synchronous in cases where it is not needed.

Change-Id: Ia07e6d293c7f5e6dfb81b06c0ffb6d5d651b88b3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2022-06-16 08:53:43 +02:00
parent 07dfd7c0b3
commit bfad59ade0
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/cdb/cdbengine.cpp
View File

@@ -265,7 +265,7 @@ void CdbEngine::init()
} }
// update source path maps from debugger start params // update source path maps from debugger start params
mergeStartParametersSourcePathMap(); mergeStartParametersSourcePathMap();
QTC_ASSERT(m_process.state() != QProcess::Running, m_process.stopProcess()); QTC_ASSERT(m_process.state() != QProcess::Running, m_process.stop());
} }
CdbEngine::~CdbEngine() = default; CdbEngine::~CdbEngine() = default;
@@ -691,7 +691,7 @@ void CdbEngine::shutdownEngine()
} }
} else { } else {
// Remote process. No can do, currently // Remote process. No can do, currently
m_process.stopProcess(); m_process.stop();
} }
} }

1
src/plugins/debugger/debuggersourcepathmappingwidget.cpp
View File

@@ -453,7 +453,6 @@ static QString findQtInstallPath(const FilePath &qmakePath)
return QString(); return QString();
} }
if (!proc.waitForFinished()) { if (!proc.waitForFinished()) {
proc.stopProcess();
qWarning("%s: Timeout running '%s'.", Q_FUNC_INFO, qPrintable(qmakePath.toString())); qWarning("%s: Timeout running '%s'.", Q_FUNC_INFO, qPrintable(qmakePath.toString()));
return QString(); return QString();
} }