feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FakeVim: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I9caa1cd8aca07a58071d566a6b300c1577f72c28
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-01 17:22:10 +01:00
parent 3bf1dc1796
commit bffd6431e3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/fakevim/fakevimhandler.cpp
View File

@@ -57,7 +57,6 @@
#include <QTextDocumentFragment> #include <QTextDocumentFragment>
#include <QTextEdit> #include <QTextEdit>
#include <QMimeData> #include <QMimeData>
#include <QSharedPointer>
#include <QDir> #include <QDir>
#include <algorithm> #include <algorithm>
@@ -2282,7 +2281,7 @@ public:
QPointer<FakeVimHandler::Private> currentHandler; QPointer<FakeVimHandler::Private> currentHandler;
}; };
using BufferDataPtr = QSharedPointer<BufferData>; using BufferDataPtr = std::shared_ptr<BufferData>;
void pullOrCreateBufferData(); void pullOrCreateBufferData();
BufferDataPtr m_buffer; BufferDataPtr m_buffer;