From c007be8a9ab764f2386b450c31f3fdec946f6db7 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Mon, 24 Jul 2023 17:33:16 +0200
Subject: [PATCH] Valgrind: Save a few cycles in updateFromSettings()

Makes it easier to debug, too.

Change-Id: Id55591195bc645cfff002d04e4fdae6e4b3a4b85
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
---
 src/plugins/valgrind/memchecktool.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/plugins/valgrind/memchecktool.cpp b/src/plugins/valgrind/memchecktool.cpp
index f08b3a7f3ce..9c6e935c77f 100644
--- a/src/plugins/valgrind/memchecktool.cpp
+++ b/src/plugins/valgrind/memchecktool.cpp
@@ -909,14 +909,17 @@ void MemcheckToolPrivate::settingsDestroyed(QObject *settings)
 
 void MemcheckToolPrivate::updateFromSettings()
 {
+    const QList<int> stored = m_settings->visibleErrorKinds();
     for (QAction *action : std::as_const(m_errorFilterActions)) {
         bool contained = true;
         const QList<QVariant> actions = action->data().toList();
         for (const QVariant &v : actions) {
             bool ok;
             int kind = v.toInt(&ok);
-            if (ok && !m_settings->visibleErrorKinds().contains(kind))
+            if (ok && !stored.contains(kind)) {
                 contained = false;
+                break;
+            }
         }
         action->setChecked(contained);
     }