feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Coco: fix crash in CocoBuildStep

Browse Source 
The bug was reported via Sentry and I could not reproduce it here, but
the immediate cause was clear: m_buildSettings was used when it was
still a null pointer - certainly because CocoBuildStep::display() was
not yet called.

I have added code that prevents this.

Fixes: QTCREATORBUG-32850
Change-Id: I8226e1466870e77749aff276de150b79f75332a4
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Markus Redeker
2025-04-23 15:57:20 +02:00
parent f4e5912d57
commit c052dda76b
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/coco/cocobuildstep.cpp
View File

@@ -77,6 +77,8 @@ void CocoBuildStep::buildSystemUpdated()
void CocoBuildStep::onButtonClicked() void CocoBuildStep::onButtonClicked()
{ {
QTC_ASSERT(m_buildSettings, return);
m_valid = !m_valid; m_valid = !m_valid;
setSummaryText(Tr::tr("Coco Code Coverage: Reconfiguring...")); setSummaryText(Tr::tr("Coco Code Coverage: Reconfiguring..."));
@@ -97,6 +99,8 @@ QWidget *CocoBuildStep::createConfigWidget()
void CocoBuildStep::updateDisplay() void CocoBuildStep::updateDisplay()
{ {
QTC_ASSERT(m_buildSettings, return);
if (!cocoSettings().isValid()) { if (!cocoSettings().isValid()) {
setSummaryText("<i>" + Tr::tr("Coco Code Coverage: No working Coco installation.") + "</i>"); setSummaryText("<i>" + Tr::tr("Coco Code Coverage: No working Coco installation.") + "</i>");
emit setButtonState(false); emit setButtonState(false);