From c0f1cd8e539dd457fa26e329d22cf915b4402458 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 6 Apr 2021 14:46:44 +0200 Subject: [PATCH] macOS: Show icons for device types in menu When selecting a device icon for a kit, we should show the actual icons in the menu even on macOS, even though icons in menus is not customary there. Task-number: QTCREATORBUG-25443 Change-Id: If0aed679b9cd3b1645bd423af70059730a522f05 Reviewed-by: Christian Kandeler --- .../projectexplorer/kitmanagerconfigwidget.cpp | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/plugins/projectexplorer/kitmanagerconfigwidget.cpp b/src/plugins/projectexplorer/kitmanagerconfigwidget.cpp index dc0797c29e7..3d40b510cb8 100644 --- a/src/plugins/projectexplorer/kitmanagerconfigwidget.cpp +++ b/src/plugins/projectexplorer/kitmanagerconfigwidget.cpp @@ -307,12 +307,15 @@ void KitManagerConfigWidget::setIcon() for (const IDeviceFactory * const factory : qAsConst(allDeviceFactories)) { if (factory->icon().isNull()) continue; - iconMenu.addAction(factory->icon(), tr("Default for %1").arg(factory->displayName()), - [this, factory] { - m_iconButton->setIcon(factory->icon()); - m_modifiedKit->setDeviceTypeForIcon(factory->deviceType()); - emit dirty(); - }); + QAction *action = iconMenu.addAction(factory->icon(), + tr("Default for %1").arg(factory->displayName()), + [this, factory] { + m_iconButton->setIcon(factory->icon()); + m_modifiedKit->setDeviceTypeForIcon( + factory->deviceType()); + emit dirty(); + }); + action->setIconVisibleInMenu(true); } iconMenu.addSeparator(); iconMenu.addAction(Utils::PathChooser::browseButtonLabel(), [this] {