From c12a80306c82605d7969ca9ffe4b2cbfd5039c06 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 10 Oct 2019 15:21:07 +0200 Subject: [PATCH] CMake: Remove clearBuildTarget from CMakeBuildStep That method makes little sense, considering that there can only ever be one build target. Change-Id: I53d555fa7d713dd8c05b4a9f5944908afeee859f Reviewed-by: Cristian Adam Reviewed-by: hjk --- src/plugins/cmakeprojectmanager/cmakebuildstep.cpp | 5 ----- src/plugins/cmakeprojectmanager/cmakebuildstep.h | 1 - src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp | 1 - 3 files changed, 7 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp index 581adade966..b27110b3760 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp @@ -321,11 +321,6 @@ void CMakeBuildStep::setBuildTarget(const QString &buildTarget) emit targetToBuildChanged(); } -void CMakeBuildStep::clearBuildTargets() -{ - m_buildTarget.clear(); -} - QString CMakeBuildStep::toolArguments() const { return m_toolArguments; diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.h b/src/plugins/cmakeprojectmanager/cmakebuildstep.h index 28c6ccb46e5..7a2b6f0c223 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildstep.h +++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.h @@ -64,7 +64,6 @@ public: QString buildTarget() const; bool buildsBuildTarget(const QString &target) const; void setBuildTarget(const QString &target); - void clearBuildTargets(); QString toolArguments() const; void setToolArguments(const QString &list); diff --git a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp index 4745dc4cfa3..f7149a4eb21 100644 --- a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp +++ b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp @@ -155,7 +155,6 @@ void BuildCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection, // Change the make step to build only the given target QString oldTarget = buildStep->buildTarget(); - buildStep->clearBuildTargets(); buildStep->setBuildTarget(selection.displayName); // Build