feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Remove clearBuildTarget from CMakeBuildStep

Browse Source 
That method makes little sense, considering that there can only ever
be one build target.

Change-Id: I53d555fa7d713dd8c05b4a9f5944908afeee859f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2019-10-10 15:21:07 +02:00
parent 7c9e118255
commit c12a80306c
3 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -321,11 +321,6 @@ void CMakeBuildStep::setBuildTarget(const QString &buildTarget)
emit targetToBuildChanged(); emit targetToBuildChanged();
} }
void CMakeBuildStep::clearBuildTargets()
{
m_buildTarget.clear();
}
QString CMakeBuildStep::toolArguments() const QString CMakeBuildStep::toolArguments() const
{ {
return m_toolArguments; return m_toolArguments;

1
src/plugins/cmakeprojectmanager/cmakebuildstep.h
View File

@@ -64,7 +64,6 @@ public:
QString buildTarget() const; QString buildTarget() const;
bool buildsBuildTarget(const QString &target) const; bool buildsBuildTarget(const QString &target) const;
void setBuildTarget(const QString &target); void setBuildTarget(const QString &target);
void clearBuildTargets();
QString toolArguments() const; QString toolArguments() const;
void setToolArguments(const QString &list); void setToolArguments(const QString &list);

1
src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
View File

@@ -155,7 +155,6 @@ void BuildCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection,
// Change the make step to build only the given target // Change the make step to build only the given target
QString oldTarget = buildStep->buildTarget(); QString oldTarget = buildStep->buildTarget();
buildStep->clearBuildTargets();
buildStep->setBuildTarget(selection.displayName); buildStep->setBuildTarget(selection.displayName);
// Build // Build