feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Target setup page: Do not dereference potentially invalid Target pointer

Browse Source 
Fixes: QTCREATORBUG-23075
Change-Id: I60d332b3ff18cf7c83e63cb87730b44ee2a47502
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2019-10-14 16:52:14 +02:00
parent 982344a799
commit c13b20f160
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/targetsettingspanel.cpp
View File

@@ -748,10 +748,8 @@ TargetItem *TargetGroupItem::currentTargetItem() const
TargetItem *TargetGroupItem::targetItem(Target *target) const TargetItem *TargetGroupItem::targetItem(Target *target) const
{ {
if (target) { if (target)
Id needle = target->id(); // Unconfigured project have no active target. return findFirstLevelChild([target](TargetItem *item) { return item->target() == target; });
return findFirstLevelChild([needle](TargetItem *item) { return item->m_kitId == needle; });
}
return nullptr; return nullptr;
} }