feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SSH: Close channels before re-using a connection.

Browse Source 
Otherwise a new client acquiring the connection could be affected by
things happening in channels that were not opened by that client, which
would certainly be unexpected.
In particular, if the new owner of the connection runs in a different
thread than the old one, crashes could occur since the connection
assumes its channels run in the same thread.

Change-Id: I4fdf2b5a3751ed506631d6878e94342da033c31c
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This commit is contained in:
Christian Kandeler
2012-06-20 15:55:30 +02:00
parent 621e5c3dbe
commit c1a89d2c61
5 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libs/ssh/sshconnection.cpp
View File

@@ -193,6 +193,15 @@ QSharedPointer<SftpChannel> SshConnection::createSftpChannel()
return d->createSftpChannel();
}
int SshConnection::closeAllChannels()
{
try {
return d->m_channelManager->closeAllChannels();
} catch (const Botan::Exception &e) {
qDebug("%s: %s", Q_FUNC_INFO, e.what());
return -1;
}
}
namespace Internal {