feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Perforce: Inline msgWhereFailed() helper

Browse Source 
Change-Id: I41da19c488e3a4a72abfb5c7912fdcbc190cc603
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-01-21 20:46:09 +01:00
parent 3769c40cbb
commit c1e8688eea
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/perforce/perforceplugin.cpp
View File

@@ -1608,14 +1608,6 @@ QString PerforcePluginPrivate::pendingChangesData()
return dataResponse.error ? QString() : dataResponse.stdOut; return dataResponse.error ? QString() : dataResponse.stdOut;
} }
static QString msgWhereFailed(const QString & file, const QString &why)
{
//: Failed to run p4 "where" to resolve a Perforce file name to a local
//: file system name.
return Tr::tr("Error running \"where\" on %1: %2").
arg(QDir::toNativeSeparators(file), why);
}
// Map a perforce name "//xx" to its real name in the file system // Map a perforce name "//xx" to its real name in the file system
QString fileNameFromPerforceName(const QString &perforceName, bool quiet) QString fileNameFromPerforceName(const QString &perforceName, bool quiet)
{ {
@@ -1640,9 +1632,11 @@ QString fileNameFromPerforceName(const QString &perforceName, bool quiet)
if (output.isEmpty()) { if (output.isEmpty()) {
if (!quiet) { if (!quiet) {
//: File is not managed by Perforce //: Failed to run p4 "where" to resolve a Perforce file name to a local
VcsOutputWindow::appendError(msgWhereFailed(perforceName, //: file system name.
Tr::tr("The file is not mapped"))); VcsOutputWindow::appendError(
Tr::tr("Error running \"where\" on %1: The file is not mapped")
.arg(QDir::toNativeSeparators(perforceName)));
} }
return {}; return {};
} }