From c209eb9fbbbdac177dca0ec5cfb3454fcb8fc262 Mon Sep 17 00:00:00 2001 From: Daniel Teske Date: Mon, 15 Jun 2015 12:39:19 +0200 Subject: [PATCH] AnalyerRunControl: Don't store the runconfiguration There is no gurantee that the runconfiguration stays alive after creation. Change-Id: Ia520cc33a89ec56ad6a9b928f841eb4551732ae0 Reviewed-by: hjk --- src/plugins/analyzerbase/analyzerruncontrol.cpp | 3 +-- src/plugins/analyzerbase/analyzerruncontrol.h | 5 ----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/plugins/analyzerbase/analyzerruncontrol.cpp b/src/plugins/analyzerbase/analyzerruncontrol.cpp index 6748220743e..48f6103bccc 100644 --- a/src/plugins/analyzerbase/analyzerruncontrol.cpp +++ b/src/plugins/analyzerbase/analyzerruncontrol.cpp @@ -53,7 +53,6 @@ AnalyzerRunControl::AnalyzerRunControl(const AnalyzerStartParameters &sp, { setIcon(QLatin1String(":/images/analyzer_start_small.png")); - m_runConfig = runConfiguration; m_sp = sp; connect(this, &AnalyzerRunControl::finished, @@ -101,7 +100,7 @@ bool AnalyzerRunControl::isRunning() const QString AnalyzerRunControl::displayName() const { - return m_runConfig ? m_runConfig->displayName() : m_sp.displayName; + return m_sp.displayName; } } // namespace Analyzer diff --git a/src/plugins/analyzerbase/analyzerruncontrol.h b/src/plugins/analyzerbase/analyzerruncontrol.h index 8b294c4c85f..8d436af6e88 100644 --- a/src/plugins/analyzerbase/analyzerruncontrol.h +++ b/src/plugins/analyzerbase/analyzerruncontrol.h @@ -68,9 +68,6 @@ public: virtual void pause() {} virtual void unpause() {} - /// The active run configuration for this engine, might be zero. - ProjectExplorer::RunConfiguration *runConfiguration() const { return m_runConfig; } - /// The start parameters for this engine. const AnalyzerStartParameters &startParameters() const { return m_sp; } @@ -98,8 +95,6 @@ signals: private: bool supportsReRunning() const { return false; } - - ProjectExplorer::RunConfiguration *m_runConfig; AnalyzerStartParameters m_sp; }; } // namespace Analyzer