feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Remove wrong todos

Browse Source 
These todos have been resolved already or turned out
to be wrong / not necessary.

Change-Id: Iefa46bd8144834a60fbb9d523ac73d3372d4a6b6
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2019-06-03 13:17:55 +02:00
parent 6b124b580e
commit c23fe4f403
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/autotest/boost/boosttestoutputreader.cpp
View File

@@ -107,7 +107,7 @@ void BoostTestOutputReader::sendCompleteInformation()
if (m_lineNumber) { if (m_lineNumber) {
result->setLine(m_lineNumber); result->setLine(m_lineNumber);
result->setFileName(m_fileName); result->setFileName(m_fileName);
} // else TODO }
result->setDescription(m_description); result->setDescription(m_description);
result->setResult(m_result); result->setResult(m_result);
@@ -406,7 +406,6 @@ TestResultPtr BoostTestOutputReader::createDefaultResult() const
result->setTestSuite(m_currentSuite); result->setTestSuite(m_currentSuite);
result->setTestCase(m_currentTest); result->setTestCase(m_currentTest);
// TODO find corresponding TestTreeItem and set filename/line
return TestResultPtr(result); return TestResultPtr(result);
} }
@@ -418,7 +417,6 @@ void BoostTestOutputReader::onFinished(int exitCode, QProcess::ExitStatus /*exit
// boost::exit_success (0), boost::exit_test_failure (201) // boost::exit_success (0), boost::exit_test_failure (201)
// or boost::exit_exception_failure (200) // or boost::exit_exception_failure (200)
// be graceful and do not add a fatal for exit_test_failure // be graceful and do not add a fatal for exit_test_failure
// but exit code 0 can be forced with an option - what todo in that case?
if (m_logLevel == LogLevel::Nothing && m_reportLevel == ReportLevel::No) { if (m_logLevel == LogLevel::Nothing && m_reportLevel == ReportLevel::No) {
switch (exitCode) { switch (exitCode) {
case 0: case 0: