From c24702427317c8611bdf0f29df14040f7de3c749 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 18 Nov 2020 12:41:14 +0100 Subject: [PATCH] ProjectExplorer: Remove QTC_CHECK in BuildStep::buildConfiguration() This keeps hitting us on all kinds of valid deployment-related code paths, resulting in silly workarounds that do not solve an actual problem. Change-Id: I5c728f91f1138fa833c6fc9ab19595060a88e19d Reviewed-by: hjk --- src/plugins/projectexplorer/buildstep.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/plugins/projectexplorer/buildstep.cpp b/src/plugins/projectexplorer/buildstep.cpp index a3b12fbeab0..b6c6f4d6219 100644 --- a/src/plugins/projectexplorer/buildstep.cpp +++ b/src/plugins/projectexplorer/buildstep.cpp @@ -212,12 +212,6 @@ BuildConfiguration *BuildStep::buildConfiguration() const if (config) return config; - // This situation should be avoided, as the step returned below is almost - // always not the right one, but the fallback is best we can do. - // A potential currently still valid path is accessing a build configuration - // from a BuildStep in a DeployConfiguration. Let's hunt those down and - // replace with explicit code there. - QTC_CHECK(false); // step is not part of a build configuration, use active build configuration of step's target return target()->activeBuildConfiguration(); }