Utils: Re-do Replace SynchronousCommand::flags by a named bool

The potential extensibility was never used, and a similar use case
in QtcProcess (setLowPriority()) used a named setter.

Change-Id: I87d84ea2206995d5069265f8df78f40cf2ba8a36
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/vcsbase/vcscommand.cpp

@@ -41,6 +41,7 @@ VcsCommand::VcsCommand(const QString &workingDirectory, const Environment &envir
     m_preventRepositoryChanged(false)
 {
     VcsOutputWindow::setRepository(workingDirectory);
+    setDisableUnixTerminal();
     setOutputProxyFactory([this] {
         auto proxy = new OutputProxy;
         VcsOutputWindow *outputWindow = VcsOutputWindow::instance();
@@ -94,14 +95,6 @@ void VcsCommand::emitRepositoryChanged(const QString &workingDirectory)
     Core::VcsManager::emitRepositoryChanged(workDirectory(workingDirectory));
 }
 
-unsigned VcsCommand::processFlags() const
-{
-    unsigned processFlags = 0;
-    if (!VcsBase::sshPrompt().isEmpty() && (flags() & SshPasswordPrompt))
-        processFlags |= SynchronousProcess::UnixTerminalDisabled;
-    return processFlags;
-}
-
 void VcsCommand::coreAboutToClose()
 {
     m_preventRepositoryChanged = true;

src/plugins/vcsbase/vcscommand.h

@@ -51,7 +51,6 @@ public:
                                                  const Utils::ExitCodeInterpreter &interpreter = Utils::defaultExitCodeInterpreter) override;
 
 private:
-    unsigned processFlags() const override;
     void emitRepositoryChanged(const QString &workingDirectory);
 
     void coreAboutToClose() override;