From c2937f609e346e4ff031d828986d1b16dc20fac7 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Tue, 20 Sep 2022 12:43:51 +0200
Subject: [PATCH] LanguageClient: Do not cancel search on empty result list

... for a rename request.
Instead, simply finish the search normally, leading to a "no matches
found" message rather than the misleading "search canceled".
But do cancel the search on an actual error.

Change-Id: I10401466bb4d81d53d26b8dc08bfed91db86cd5a
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/languageclient/languageclientsymbolsupport.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/languageclient/languageclientsymbolsupport.cpp b/src/plugins/languageclient/languageclientsymbolsupport.cpp
index a813e3c8959..50675238e79 100644
--- a/src/plugins/languageclient/languageclientsymbolsupport.cpp
+++ b/src/plugins/languageclient/languageclientsymbolsupport.cpp
@@ -384,7 +384,7 @@ void SymbolSupport::handleRenameResponse(Core::SearchResult *search,
         search->setSearchAgainEnabled(false);
         search->finishSearch(false);
     } else {
-        search->finishSearch(true);
+        search->finishSearch(error.has_value());
     }
 }