feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Use document visibility as jobrequest conditions

Browse Source 
This is in preparation for a follow-up change that will add jobs that
also operate on invisible documents.

Change-Id: I2a0fc3b95cc5ab2e267429134a534df64c901376
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Nikolai Kosjar
2017-07-28 15:13:23 +02:00
parent 643854cb8b
commit c2cfc62f08
4 changed files with 42 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/unit/unittest/clangjobqueue-test.cpp
View File

@@ -65,9 +65,6 @@ protected:
JobRequest::Type type,
PreferredTranslationUnit preferredTranslationUnit
= PreferredTranslationUnit::RecentlyParsed) const;
JobRequest createJobRequestWithConditions(const Utf8String &filePath,
JobRequest::Type type,
JobRequest::Conditions conditions) const;
void updateDocumentRevision();
void updateUnsavedFiles();
@@ -415,9 +412,7 @@ TEST_F(JobQueue, RequestCompleteCodeOutdatableByDocumentRevisionChange)
TEST_F(JobQueue, RequestReferencesRunsForCurrentDocumentRevision)
{
jobQueue.add( createJobRequestWithConditions(filePath1,
JobRequest::Type::RequestReferences,
JobRequest::Condition::CurrentDocumentRevision));
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::RequestReferences));
const JobRequests jobsToStart = jobQueue.processQueue();
@@ -426,9 +421,7 @@ TEST_F(JobQueue, RequestReferencesRunsForCurrentDocumentRevision)
TEST_F(JobQueue, RequestReferencesOutdatableByDocumentClose)
{
jobQueue.add(createJobRequestWithConditions(filePath1,
JobRequest::Type::RequestReferences,
JobRequest::Condition::CurrentDocumentRevision));
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::RequestReferences));
removeDocument();
const JobRequests jobsToStart = jobQueue.processQueue();
@@ -488,18 +481,6 @@ JobRequest JobQueue::createJobRequest(
return jobRequest;
}
JobRequest JobQueue::createJobRequestWithConditions(const Utf8String &filePath,
JobRequest::Type type,
JobRequest::Conditions conditions) const
{
JobRequest jobRequest = createJobRequest(filePath,
type,
PreferredTranslationUnit::RecentlyParsed);
jobRequest.conditions = conditions;
return jobRequest;
}
void JobQueue::updateDocumentRevision()
{
documents.update({FileContainer(filePath1, projectPartId, Utf8String(), true, 1)});