Debugger: Reduce explicit DebuggerRunControl use

Aim is to replace it with its ProjectExplorer::RunControl base.

Change-Id: I30f837050e7c016887dc4b6cfef10b947f4f88ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/android/androiddebugsupport.cpp

@@ -150,11 +150,11 @@ AndroidDebugSupport::AndroidDebugSupport(RunControl *runControl)
     connect(runControl, &RunControl::finished,
             m_runner, &AndroidRunner::stop);
 
-    connect(this->runControl(), &DebuggerRunControl::requestRemoteSetup,
+    connect(this->runControl()->toolRunner(), &DebuggerRunTool::requestRemoteSetup,
             m_runner, &AndroidRunner::start);
 
     // FIXME: Move signal to base class and generalize handling.
-    connect(this->runControl(), &DebuggerRunControl::aboutToNotifyInferiorSetupOk,
+    connect(this->runControl()->toolRunner(), &DebuggerRunTool::aboutToNotifyInferiorSetupOk,
             m_runner, &AndroidRunner::remoteDebuggerRunning);
 
     connect(m_runner, &AndroidRunner::remoteServerRunning,

src/plugins/autotest/testrunner.cpp

@@ -336,8 +336,8 @@ void TestRunner::debugTests()
     sp.displayName = config->displayName();
 
     QString errorMessage;
-    Debugger::DebuggerRunControl *runControl = Debugger::createDebuggerRunControl(
+    auto runControl = Debugger::createDebuggerRunControl(sp, config->runConfiguration(),
-                sp, config->runConfiguration(), &errorMessage);
+                                                         &errorMessage);
 
     if (!runControl) {
         emit testResultReady(TestResultPtr(new FaultyTestResult(Result::MessageFatal,
@@ -374,7 +374,7 @@ void TestRunner::debugTests()
                 outputreader, &QObject::deleteLater);
     }
 
-    connect(this, &TestRunner::requestStopTestRun, runControl, &Debugger::DebuggerRunControl::stop);
+    connect(this, &TestRunner::requestStopTestRun, runControl, &ProjectExplorer::RunControl::stop);
     connect(runControl, &Debugger::DebuggerRunControl::finished, this, &TestRunner::onFinished);
     ProjectExplorer::ProjectExplorerPlugin::startRunControl(runControl);
 }

src/plugins/baremetal/baremetaldebugsupport.cpp

@@ -46,7 +46,7 @@ BareMetalDebugSupport::BareMetalDebugSupport(RunControl *runControl)
     : ToolRunner(runControl)
     , m_appLauncher(new ProjectExplorer::ApplicationLauncher(this))
 {
-    connect(this->runControl(), &Debugger::DebuggerRunControl::requestRemoteSetup,
+    connect(this->runControl()->toolRunner(), &Debugger::DebuggerRunTool::requestRemoteSetup,
             this, &BareMetalDebugSupport::remoteSetupRequested);
     connect(runControl, &RunControl::finished,
             this, &BareMetalDebugSupport::debuggingFinished);

src/plugins/baremetal/baremetalruncontrolfactory.cpp

@@ -135,7 +135,7 @@ RunControl *BareMetalRunControlFactory::create(
     if (p->startupMode() == GdbServerProvider::StartupOnNetwork)
         sp.remoteSetupNeeded = true;
 
-    DebuggerRunControl *runControl = createDebuggerRunControl(sp, rc, errorMessage, mode);
+    auto runControl = createDebuggerRunControl(sp, rc, errorMessage, mode);
     if (runControl && sp.remoteSetupNeeded)
         new BareMetalDebugSupport(runControl);
 

src/plugins/debugger/debuggerengine.cpp

@@ -343,7 +343,7 @@ public:
     bool isMasterEngine() const { return m_engine->isMasterEngine(); }
     DebuggerRunTool *runTool() const
         { return m_masterEngine ? m_masterEngine->runTool() : m_runTool.data(); }
-    DebuggerRunControl *runControl() const { return runTool()->runControl(); }
+    RunControl *runControl() const { return runTool()->runControl(); }
     void setRemoteSetupState(RemoteSetupState state);
 
     DebuggerEngine *m_engine = nullptr; // Not owned.
@@ -1518,7 +1518,7 @@ void DebuggerEngine::progressPing()
     d->m_progress.setProgressValue(progress);
 }
 
-DebuggerRunControl *DebuggerEngine::runControl() const
+RunControl *DebuggerEngine::runControl() const
 {
     return d->runControl();
 }

src/plugins/debugger/debuggerengine.h

@@ -53,7 +53,6 @@ class ProcessHandle;
 
 namespace Debugger {
 
-class DebuggerRunControl;
 class RemoteSetupResult;
 class DebuggerRunTool;
 
@@ -433,7 +432,7 @@ protected:
     void setTargetState(DebuggerState state);
     void setMasterEngine(DebuggerEngine *masterEngine);
 
-    DebuggerRunControl *runControl() const;
+    ProjectExplorer::RunControl *runControl() const;
     Terminal *terminal() const;
 
     static QString msgStopped(const QString &reason = QString());

src/plugins/debugger/debuggerplugin.cpp

@@ -1914,7 +1914,7 @@ void DebuggerPluginPrivate::onCurrentProjectChanged(Project *project)
     for (int i = 0, n = m_snapshotHandler->size(); i != n; ++i) {
         // Run controls might be deleted during exit.
         if (DebuggerEngine *engine = m_snapshotHandler->at(i)) {
-            if (DebuggerRunControl *runControl = engine->runControl()) {
+            if (RunControl *runControl = engine->runControl()) {
                 RunConfiguration *rc = runControl->runConfiguration();
                 if (rc == activeRc) {
                     m_snapshotHandler->setCurrentIndex(i);

src/plugins/debugger/debuggerruncontrol.cpp

@@ -541,11 +541,11 @@ DebuggerRunTool::DebuggerRunTool(RunControl *runControl, const DebuggerRunParame
     connect(runControl, &RunControl::finished,
             this, &DebuggerRunTool::handleFinished);
     connect(m_engine, &DebuggerEngine::requestRemoteSetup,
-            this->runControl(), &DebuggerRunControl::requestRemoteSetup);
+            this, &DebuggerRunTool::requestRemoteSetup);
     connect(m_engine, &DebuggerEngine::stateChanged,
-            this->runControl(), &DebuggerRunControl::stateChanged);
+            this, &DebuggerRunTool::stateChanged);
     connect(m_engine, &DebuggerEngine::aboutToNotifyInferiorSetupOk,
-            this->runControl(), &DebuggerRunControl::aboutToNotifyInferiorSetupOk);
+            this, &DebuggerRunTool::aboutToNotifyInferiorSetupOk);
 }
 
 DebuggerRunTool::~DebuggerRunTool()
@@ -692,10 +692,10 @@ RunControl *createAndScheduleRun(const DebuggerRunParameters &rp, Kit *kit)
 /**
  * Main entry point for target plugins.
  */
-DebuggerRunControl *createDebuggerRunControl(const DebuggerStartParameters &sp,
+RunControl *createDebuggerRunControl(const DebuggerStartParameters &sp,
-                                             RunConfiguration *runConfig,
+                                     RunConfiguration *runConfig,
-                                             QString *errorMessage,
+                                     QString *errorMessage,
-                                             Core::Id runMode)
+                                     Core::Id runMode)
 {
     QTC_ASSERT(runConfig, return nullptr);
     auto runControl = new DebuggerRunControl(runConfig, runMode);

src/plugins/debugger/debuggerruncontrol.h

@@ -37,10 +37,11 @@ class RemoteSetupResult;
 class DebuggerStartParameters;
 class DebuggerRunControl;
 
-DEBUGGER_EXPORT DebuggerRunControl *createDebuggerRunControl(const DebuggerStartParameters &sp,
+DEBUGGER_EXPORT ProjectExplorer::RunControl *
-                                                             ProjectExplorer::RunConfiguration *runConfig,
+createDebuggerRunControl(const DebuggerStartParameters &sp,
-                                                             QString *errorMessage,
+                         ProjectExplorer::RunConfiguration *runConfig,
-                                                             Core::Id runMode = ProjectExplorer::Constants::DEBUG_RUN_MODE);
+                         QString *errorMessage,
+                         Core::Id runMode = ProjectExplorer::Constants::DEBUG_RUN_MODE);
 
 class DEBUGGER_EXPORT DebuggerRunTool : public ProjectExplorer::ToolRunner
 {
@@ -76,6 +77,11 @@ public:
 
     DebuggerStartParameters &startParameters(); // Used in Boot2Qt.
 
+signals:
+    void stateChanged(Debugger::DebuggerState state);
+    void aboutToNotifyInferiorSetupOk();
+    void requestRemoteSetup();
+
 private:
     Internal::DebuggerEngine *m_engine = nullptr; // Master engine
     QStringList m_errors;
@@ -94,11 +100,6 @@ public:
 
     DebuggerRunTool *toolRunner() const;
 
-signals:
-    void requestRemoteSetup();
-    void aboutToNotifyInferiorSetupOk();
-    void stateChanged(Debugger::DebuggerState state);
-
 public:
     DebuggerRunTool *m_debuggerTool = nullptr;
 };

src/plugins/ios/iosdebugsupport.cpp

@@ -166,7 +166,7 @@ IosDebugSupport::IosDebugSupport(RunControl *runControl, bool cppDebug, bool qml
       m_runner(new IosRunner(this, runControl, cppDebug,
                              qmlDebug ? QmlDebug::QmlDebuggerServices : QmlDebug::NoQmlDebugServices))
 {
-    connect(this->runControl(), &DebuggerRunControl::requestRemoteSetup,
+    connect(this->runControl()->toolRunner(), &DebuggerRunTool::requestRemoteSetup,
             m_runner, &IosRunner::start);
     connect(runControl, &RunControl::finished,
             m_runner, &IosRunner::stop);

src/plugins/qnx/qnxattachdebugsupport.cpp

@@ -134,7 +134,7 @@ void QnxAttachDebugSupport::attachToProcess()
         sp.solibSearchPath = QnxUtils::searchPaths(qtVersion);
 
     QString errorMessage;
-    Debugger::DebuggerRunControl *runControl = Debugger::createDebuggerRunControl(sp, 0, &errorMessage);
+    auto runControl = Debugger::createDebuggerRunControl(sp, 0, &errorMessage);
     if (!errorMessage.isEmpty()) {
         handleError(errorMessage);
         stopPDebug();
@@ -145,7 +145,8 @@ void QnxAttachDebugSupport::attachToProcess()
         stopPDebug();
         return;
     }
-    connect(runControl, &Debugger::DebuggerRunControl::stateChanged,
+    connect(qobject_cast<Debugger::DebuggerRunTool *>(runControl->toolRunner()),
+            &Debugger::DebuggerRunTool::stateChanged,
             this, &QnxAttachDebugSupport::handleDebuggerStateChanged);
     ProjectExplorerPlugin::startRunControl(runControl);
 }

src/plugins/qnx/qnxdebugsupport.cpp

@@ -61,7 +61,7 @@ QnxDebugSupport::QnxDebugSupport(RunControl *runControl)
     connect(runner, &ApplicationLauncher::remoteStdout, this, &QnxDebugSupport::handleRemoteOutput);
     connect(runner, &ApplicationLauncher::remoteStderr, this, &QnxDebugSupport::handleRemoteOutput);
 
-    connect(this->runControl(), &Debugger::DebuggerRunControl::requestRemoteSetup,
+    connect(this->runControl()->toolRunner(), &Debugger::DebuggerRunTool::requestRemoteSetup,
             this, &QnxDebugSupport::handleAdapterSetupRequested);
     connect(runControl, &RunControl::finished,
             this, &QnxDebugSupport::handleDebuggingFinished);

src/plugins/qnx/qnxruncontrolfactory.cpp

@@ -132,7 +132,7 @@ RunControl *QnxRunControlFactory::create(RunConfiguration *runConfig, Core::Id m
 
     if (mode == ProjectExplorer::Constants::DEBUG_RUN_MODE) {
         const DebuggerStartParameters params = createDebuggerStartParameters(rc);
-        DebuggerRunControl *runControl = createDebuggerRunControl(params, runConfig, errorMessage);
+        auto runControl = createDebuggerRunControl(params, runConfig, errorMessage);
         QTC_ASSERT(runControl, return 0);
         (void) new QnxDebugSupport(runControl);
         return runControl;

src/plugins/remotelinux/remotelinuxdebugsupport.cpp

@@ -79,7 +79,7 @@ LinuxDeviceDebugSupport::LinuxDeviceDebugSupport(RunControl *runControl,
     : DebuggerRunTool(runControl, sp, errorMessage),
       d(new LinuxDeviceDebugSupportPrivate(runControl->runConfiguration()))
 {
-    connect(this->runControl(), &DebuggerRunControl::requestRemoteSetup,
+    connect(this, &DebuggerRunTool::requestRemoteSetup,
             this, &LinuxDeviceDebugSupport::handleRemoteSetupRequested);
     connect(runControl, &RunControl::finished,
             this, &LinuxDeviceDebugSupport::handleDebuggingFinished);
@@ -113,11 +113,6 @@ void LinuxDeviceDebugSupport::showMessage(const QString &msg, int channel)
         runControl()->toolRunner()->showMessage(msg, channel);
 }
 
-DebuggerRunControl *LinuxDeviceDebugSupport::runControl() const
-{
-    return qobject_cast<DebuggerRunControl *>(ToolRunner::runControl());
-}
-
 AbstractRemoteLinuxRunSupport *LinuxDeviceDebugSupport::targetRunner() const
 {
     return qobject_cast<AbstractRemoteLinuxRunSupport *>(runControl()->targetRunner());

src/plugins/remotelinux/remotelinuxdebugsupport.h

@@ -47,7 +47,6 @@ protected:
     virtual ProjectExplorer::Runnable realRunnable() const;
     bool isCppDebugging() const;
     bool isQmlDebugging() const;
-    Debugger::DebuggerRunControl *runControl() const;
 
 private:
     void startExecution();

src/plugins/winrt/winrtdebugsupport.cpp

@@ -144,7 +144,7 @@ RunControl *WinRtDebugSupport::createDebugRunControl(WinRtRunConfiguration *runC
                     return 0;
                 }
                 server.close();
-                Debugger::DebuggerRunControl *debugRunControl
+                auto debugRunControl
                         = createDebuggerRunControl(params, runConfig, errorMessage, mode);
                 runner->setDebugRunControl(debugRunControl);
                 new WinRtDebugSupport(debugRunControl, runner);

src/plugins/winrt/winrtrunnerhelper.cpp

@@ -146,9 +146,9 @@ bool WinRtRunnerHelper::waitForStarted(int msecs)
     return m_process->waitForStarted(msecs);
 }
 
-void WinRtRunnerHelper::setDebugRunControl(Debugger::DebuggerRunControl *runControl)
+void WinRtRunnerHelper::setDebugRunControl(ProjectExplorer::RunControl *runControl)
 {
-    m_debugMessenger = runControl->toolRunner();
+    m_debugMessenger = qobject_cast<Debugger::DebuggerRunTool *>(runControl->toolRunner());
     m_messenger = runControl;
 }
 

src/plugins/winrt/winrtrunnerhelper.h

@@ -36,11 +36,7 @@
 
 namespace Utils { class QtcProcess; }
 namespace ProjectExplorer { class RunControl; }
-
+namespace Debugger { class DebuggerRunTool; }
-namespace Debugger {
-class DebuggerRunControl;
-class DebuggerRunTool;
-}
 
 namespace WinRt {
 namespace Internal {
@@ -60,7 +56,7 @@ public:
     void stop();
 
     bool waitForStarted(int msecs = 10000);
-    void setDebugRunControl(Debugger::DebuggerRunControl *runControl);
+    void setDebugRunControl(ProjectExplorer::RunControl *runControl);
 
 signals:
     void started();