feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: split out settings specific for std io clients

Browse Source 
Change-Id: I25eebfc15a9d0d5665e57137f016e54a069ca849
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2018-09-18 10:43:17 +02:00
parent 0ebe8402c7
commit c37bedfb02
5 changed files with 165 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/languageclient/baseclient.cpp
View File

@@ -499,6 +499,11 @@ bool BaseClient::isSupportedMimeType(const QString &mimeType) const
return m_supportedMimeTypes.isEmpty() || m_supportedMimeTypes.contains(mimeType);
}
bool BaseClient::needsRestart(const BaseSettings *) const
{
return false;
}
bool BaseClient::reset()
{
if (!m_restartsLeft)
@@ -756,6 +761,11 @@ StdIOClient::~StdIOClient()
Utils::SynchronousProcess::stopProcess(m_process);
}
bool StdIOClient::needsRestart(const StdIOSettings *settings)
{
return m_executable != settings->m_executable || m_arguments != settings->m_arguments;
}
bool StdIOClient::start()
{
m_process.start();
@@ -771,11 +781,6 @@ void StdIOClient::setWorkingDirectory(const QString &workingDirectory)
m_process.setWorkingDirectory(workingDirectory);
}
bool StdIOClient::matches(const BaseSettings *setting)
{
return setting->m_executable == m_executable && setting->m_arguments == m_arguments;
}
void StdIOClient::sendData(const QByteArray &data)
{
if (m_process.state() != QProcess::Running) {