IDevice: Make fromMap() / toMap() protected

Change-Id: I9a8f1caddffaf4e0f446ccc4f08f1110b6c003d4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>

src/plugins/android/androiddevice.h

@@ -46,8 +46,6 @@ class AndroidDevice final : public ProjectExplorer::IDevice
 public:
     AndroidDevice();
 
-    void fromMap(const QVariantMap &map) override;
-
     static IDevice::Ptr create();
     static AndroidDeviceInfo androidDeviceInfoFromIDevice(const IDevice *dev);
     static void setAndroidDeviceInfoExtras(IDevice *dev, const AndroidDeviceInfo &info);
@@ -74,6 +72,9 @@ public:
     QString openGlStatusString() const;
     AndroidConfig::OpenGl openGlStatus() const;
 
+protected:
+    void fromMap(const QVariantMap &map) final;
+
 private:
     void addEmulatorActionsIfNotFound();
     ProjectExplorer::IDevice::DeviceInfo deviceInformation() const override;

src/plugins/baremetal/baremetaldevice.h

@@ -57,6 +57,7 @@ public:
     void setDebugServerProviderId(const QString &id);
     void unregisterDebugServerProvider(IDebugServerProvider *provider);
 
+protected:
     void fromMap(const QVariantMap &map) final;
     QVariantMap toMap() const final;
 

src/plugins/boot2qt/qdbdevice.h

@@ -49,11 +49,12 @@ public:
     void setSerialNumber(const QString &serial);
     QString serialNumber() const;
 
+    void setupDefaultNetworkSettings(const QString &host);
+
+protected:
     void fromMap(const QVariantMap &map) final;
     QVariantMap toMap() const final;
 
-    void setupDefaultNetworkSettings(const QString &host);
-
 private:
     QdbDevice();
 

src/plugins/docker/dockerdevice.h

@@ -119,13 +119,15 @@ public:
     Utils::FilePath mapFromLocalAccess(const Utils::FilePath &filePath) const;
     Utils::FilePath mapFromLocalAccess(const QString &filePath) const;
 
+protected:
+    void fromMap(const QVariantMap &map) final;
+    QVariantMap toMap() const final;
+
 private:
     Utils::FilePaths findFilesWithFind(const Utils::FilePath &filePath,
                                        const QStringList &nameFilters,
                                        QDir::Filters filters,
                                        QDir::SortFlags sort) const;
-    void fromMap(const QVariantMap &map) final;
-    QVariantMap toMap() const final;
 
     void aboutToBeRemoved() const final;
 

src/plugins/ios/iosdevice.h

@@ -55,8 +55,6 @@ public:
     ProjectExplorer::IDeviceWidget *createWidget() override;
     ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;
 
-    void fromMap(const QVariantMap &map) override;
-    QVariantMap toMap() const override;
     QString deviceName() const;
     QString uniqueDeviceID() const;
     QString uniqueInternalDeviceId() const;
@@ -68,6 +66,9 @@ public:
     static QString name();
 
 protected:
+    void fromMap(const QVariantMap &map) final;
+    QVariantMap toMap() const final;
+
     friend class IosDeviceFactory;
     friend class Ios::Internal::IosDeviceManager;
     IosDevice();

src/plugins/projectexplorer/devicesupport/idevice.h

@@ -193,9 +193,6 @@ public:
     void setDeviceState(const DeviceState state);
     QString deviceStateToString() const;
 
-    virtual void fromMap(const QVariantMap &map);
-    virtual QVariantMap toMap() const;
-
     static Utils::Id typeFromMap(const QVariantMap &map);
     static Utils::Id idFromMap(const QVariantMap &map);
 
@@ -289,6 +286,9 @@ public:
 protected:
     IDevice();
 
+    virtual void fromMap(const QVariantMap &map);
+    virtual QVariantMap toMap() const;
+
     using OpenTerminal = std::function<void(const Utils::Environment &, const Utils::FilePath &)>;
     void setOpenTerminal(const OpenTerminal &openTerminal);
     void setDisplayType(const QString &type);

src/plugins/qnx/qnxdevice.h

@@ -51,10 +51,10 @@ public:
 
     int qnxVersion() const;
 
-    void fromMap(const QVariantMap &map) override;
-    QVariantMap toMap() const override;
-
 protected:
+    void fromMap(const QVariantMap &map) final;
+    QVariantMap toMap() const final;
+
     QString interruptProcessByNameCommandLine(const QString &filePath) const;
     QString killProcessByNameCommandLine(const QString &filePath) const;
 

src/plugins/winrt/winrtdevice.h

@@ -43,13 +43,15 @@ public:
 
     ProjectExplorer::IDeviceWidget *createWidget() override;
     ProjectExplorer::DeviceProcessSignalOperation::Ptr signalOperation() const override;
-    void fromMap(const QVariantMap &map) override;
-    QVariantMap toMap() const override;
 
     static QString displayNameForType(Utils::Id type);
     int deviceId() const { return m_deviceId; }
     void setDeviceId(int deviceId) { m_deviceId = deviceId; }
 
+protected:
+    void fromMap(const QVariantMap &map) final;
+    QVariantMap toMap() const final;
+
 private:
     WinRtDevice();