From c3ab90e30f223ca7a8111a7f822a63d6c8adacbe Mon Sep 17 00:00:00 2001
From: David Schulz <david.schulz@qt.io>
Date: Wed, 24 Mar 2021 14:44:09 +0100
Subject: [PATCH] Utils: directly use default value if settingsKey is not
 defined

This saves one value > variant > value transformation.

Change-Id: I16e5c464017fdcc0b9a07b895bbe90423022ac83
Reviewed-by: hjk <hjk@qt.io>
---
 src/libs/utils/aspects.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libs/utils/aspects.cpp b/src/libs/utils/aspects.cpp
index a1ff90d82a1..a102aaf3c51 100644
--- a/src/libs/utils/aspects.cpp
+++ b/src/libs/utils/aspects.cpp
@@ -506,8 +506,8 @@ void BaseAspect::readSettings(const QSettings *settings)
 {
     if (settingsKey().isEmpty())
         return;
-    const QVariant val = settings->value(settingsKey(), toSettingsValue(defaultValue()));
-    setValue(fromSettingsValue(val));
+    const QVariant &val = settings->value(settingsKey());
+    setValue(val.isValid() ? fromSettingsValue(val) : defaultValue());
 }
 
 void BaseAspect::writeSettings(QSettings *settings) const