From c3c99174e43dea4bab0b78fcd5055f8b8d854a1d Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 14 Feb 2023 10:10:20 +0100 Subject: [PATCH] Use common tool tip for "Configure..." kind of buttons We have a function that centralizes the text for that. Change-Id: I9d9fbed6e111038e7512030e199b8d8d03fbbafa Reviewed-by: Leena Miettinen Reviewed-by: Reviewed-by: Orgad Shaneh --- src/plugins/coreplugin/coreplugin.cpp | 2 +- src/plugins/projectexplorer/appoutputpane.cpp | 2 +- src/plugins/projectexplorer/compileoutputwindow.cpp | 2 +- src/plugins/vcsbase/submiteditorwidget.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/coreplugin/coreplugin.cpp b/src/plugins/coreplugin/coreplugin.cpp index b02a47d4f0e..043bdba74d1 100644 --- a/src/plugins/coreplugin/coreplugin.cpp +++ b/src/plugins/coreplugin/coreplugin.cpp @@ -436,7 +436,7 @@ void CorePlugin::warnAboutCrashReporing() Utils::InfoBarEntry info(kWarnCrashReportingSetting, warnStr, Utils::InfoBarEntry::GlobalSuppression::Enabled); - info.addCustomButton(Tr::tr("Configure..."), [] { + info.addCustomButton(ICore::msgShowOptionsDialog(), [] { ICore::infoBar()->removeInfo(kWarnCrashReportingSetting); ICore::infoBar()->globallySuppressInfo(kWarnCrashReportingSetting); ICore::showOptionsDialog(Core::Constants::SETTINGS_ID_SYSTEM); diff --git a/src/plugins/projectexplorer/appoutputpane.cpp b/src/plugins/projectexplorer/appoutputpane.cpp index a5590a7bb1b..3e1927faeb7 100644 --- a/src/plugins/projectexplorer/appoutputpane.cpp +++ b/src/plugins/projectexplorer/appoutputpane.cpp @@ -188,7 +188,7 @@ AppOutputPane::AppOutputPane() : connect(this, &IOutputPane::zoomOutRequested, this, &AppOutputPane::zoomOut); connect(this, &IOutputPane::resetZoomRequested, this, &AppOutputPane::resetZoom); - m_settingsButton->setToolTip(Tr::tr("Open Settings Page")); + m_settingsButton->setToolTip(Core::ICore::msgShowOptionsDialog()); m_settingsButton->setIcon(Utils::Icons::SETTINGS_TOOLBAR.icon()); connect(m_settingsButton, &QToolButton::clicked, this, [] { Core::ICore::showOptionsDialog(OPTIONS_PAGE_ID); diff --git a/src/plugins/projectexplorer/compileoutputwindow.cpp b/src/plugins/projectexplorer/compileoutputwindow.cpp index 55680befb6c..f345792ca83 100644 --- a/src/plugins/projectexplorer/compileoutputwindow.cpp +++ b/src/plugins/projectexplorer/compileoutputwindow.cpp @@ -64,7 +64,7 @@ CompileOutputWindow::CompileOutputWindow(QAction *cancelBuildAction) : Utils::ProxyAction::proxyActionWithIcon(cancelBuildAction, Utils::Icons::STOP_SMALL_TOOLBAR.icon()); m_cancelBuildButton->setDefaultAction(cancelBuildProxyButton); - m_settingsButton->setToolTip(Tr::tr("Open Settings Page")); + m_settingsButton->setToolTip(Core::ICore::msgShowOptionsDialog()); m_settingsButton->setIcon(Utils::Icons::SETTINGS_TOOLBAR.icon()); auto updateFontSettings = [this] { diff --git a/src/plugins/vcsbase/submiteditorwidget.cpp b/src/plugins/vcsbase/submiteditorwidget.cpp index 7a67a67bb21..0987faf60ab 100644 --- a/src/plugins/vcsbase/submiteditorwidget.cpp +++ b/src/plugins/vcsbase/submiteditorwidget.cpp @@ -188,7 +188,7 @@ SubmitEditorWidget::SubmitEditorWidget() : d->buttonLayout->setContentsMargins(0, -1, -1, -1); QToolButton *openSettingsButton = new QToolButton; openSettingsButton->setIcon(Utils::Icons::SETTINGS.icon()); - openSettingsButton->setToolTip(Tr::tr("Open Settings Page...")); + openSettingsButton->setToolTip(Core::ICore::msgShowOptionsDialog()); connect(openSettingsButton, &QToolButton::clicked, this, [] { Core::ICore::showOptionsDialog(Constants::VCS_COMMON_SETTINGS_ID); });