From c3d9293004f0a69aba106b4e13bcc241fbbb1dc3 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@qt.io>
Date: Wed, 18 Aug 2021 15:44:30 +0200
Subject: [PATCH] Fix some compiler warnings

Change-Id: Ibc354e7a8d0342eb12b2b0f9b2c630d15422f22a
Reviewed-by: hjk <hjk@qt.io>
---
 src/plugins/bineditor/bineditorplugin.cpp                       | 2 +-
 src/plugins/debugger/cdb/cdbengine.cpp                          | 2 +-
 src/plugins/mercurial/mercurialclient.cpp                       | 1 +
 src/plugins/projectexplorer/devicesupport/idevice.cpp           | 1 +
 .../designercore/projectstorage/projectstoragetypes.h           | 2 +-
 5 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/plugins/bineditor/bineditorplugin.cpp b/src/plugins/bineditor/bineditorplugin.cpp
index a24d21417f3..1ca61f0baee 100644
--- a/src/plugins/bineditor/bineditorplugin.cpp
+++ b/src/plugins/bineditor/bineditorplugin.cpp
@@ -280,7 +280,7 @@ public:
             return OpenResult::CannotHandle;
         }
 
-        if (offset >= size)
+        if (offset >= quint64(size))
             return OpenResult::CannotHandle;
 
         setFilePath(filePath);
diff --git a/src/plugins/debugger/cdb/cdbengine.cpp b/src/plugins/debugger/cdb/cdbengine.cpp
index e053ebd1be2..cfb12082b15 100644
--- a/src/plugins/debugger/cdb/cdbengine.cpp
+++ b/src/plugins/debugger/cdb/cdbengine.cpp
@@ -179,8 +179,8 @@ void addCdbOptionPages(QList<Core::IOptionsPage *> *opts)
 #define QT_CREATOR_CDB_EXT "qtcreatorcdbext"
 
 CdbEngine::CdbEngine() :
-    m_process(ProcessMode::Writer),
     m_tokenPrefix("<token>"),
+    m_process(ProcessMode::Writer),
     m_extensionCommandPrefix("!" QT_CREATOR_CDB_EXT ".")
 {
     setObjectName("CdbEngine");
diff --git a/src/plugins/mercurial/mercurialclient.cpp b/src/plugins/mercurial/mercurialclient.cpp
index 8fa54da42f6..2f06a8a8247 100644
--- a/src/plugins/mercurial/mercurialclient.cpp
+++ b/src/plugins/mercurial/mercurialclient.cpp
@@ -117,6 +117,7 @@ bool MercurialClient::synchronousClone(const FilePath &workingDirectory,
                                        const QString &dstLocation,
                                        const QStringList &extraOptions)
 {
+    Q_UNUSED(srcLocation)
     Q_UNUSED(extraOptions)
     const unsigned flags = VcsCommand::SshPasswordPrompt |
             VcsCommand::ShowStdOut |
diff --git a/src/plugins/projectexplorer/devicesupport/idevice.cpp b/src/plugins/projectexplorer/devicesupport/idevice.cpp
index a61250272a6..e7de6bd8d60 100644
--- a/src/plugins/projectexplorer/devicesupport/idevice.cpp
+++ b/src/plugins/projectexplorer/devicesupport/idevice.cpp
@@ -418,6 +418,7 @@ Environment IDevice::systemEnvironment() const
 
 qint64 IDevice::fileSize(const FilePath &filePath) const
 {
+    Q_UNUSED(filePath)
     QTC_CHECK(false);
     return -1;
 }
diff --git a/src/plugins/qmldesigner/designercore/projectstorage/projectstoragetypes.h b/src/plugins/qmldesigner/designercore/projectstorage/projectstoragetypes.h
index c565a036051..b5e8a14a31d 100644
--- a/src/plugins/qmldesigner/designercore/projectstorage/projectstoragetypes.h
+++ b/src/plugins/qmldesigner/designercore/projectstorage/projectstoragetypes.h
@@ -481,10 +481,10 @@ public:
         , functionDeclarations{std::move(functionDeclarations)}
         , signalDeclarations{std::move(signalDeclarations)}
         , enumerationDeclarations{std::move(enumerationDeclarations)}
+        , import{std::move(import)}
         , accessSemantics{accessSemantics}
         , sourceId{sourceId}
         , typeId{typeId}
-        , import{std::move(import)}
     {}
 
     explicit Type(Utils::SmallStringView importName,