From c3dee6857338bb0e191dbbc63c7711026782a712 Mon Sep 17 00:00:00 2001
From: Ali Kianian <ali.kianian@qt.io>
Date: Tue, 27 Jun 2023 10:09:54 +0300
Subject: [PATCH] QmlDesigner: Unmark the reflection flage for valid Qml
 property changes

The reflection flag is unmarked for valid Qml property changes in order
to be updated in the puppet side.

Task-number: QDS-9881
Change-Id: Ibd36fb1ee844f08efa256d28514a3f0debd467e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 .../designercore/instances/nodeinstanceview.cpp            | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
index 4c3e4a2e26f..bdbb2b7ee7b 100644
--- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
+++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
@@ -1307,17 +1307,20 @@ ChangeValuesCommand NodeInstanceView::createChangeValueCommand(const QList<Varia
 {
     QVector<PropertyValueContainer> containerList;
 
-    const bool reflectionFlag = m_puppetTransaction.isValid() && (!currentTimeline().isValid() || !currentTimeline().isRecording());
+    bool reflectionFlag = m_puppetTransaction.isValid()
+                          && (!currentTimeline().isValid() || !currentTimeline().isRecording());
 
     for (const VariantProperty &property : propertyList) {
         ModelNode node = property.parentModelNode();
+        if (QmlPropertyChanges::isValidQmlPropertyChanges(node))
+            reflectionFlag = false;
+
         if (node.isValid() && hasInstanceForModelNode(node)) {
             NodeInstance instance = instanceForModelNode(node);
             PropertyValueContainer container(instance.instanceId(), property.name(), property.value(), property.dynamicTypeName());
             container.setReflectionFlag(reflectionFlag);
             containerList.append(container);
         }
-
     }
 
     return ChangeValuesCommand(containerList);