feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Several SettingsPages: Code cosmetics

Browse Source 
De-Q_OBJECT-ify, remove unnecessary #includes, final-ize, etc.

Change-Id: I461d3e73400dacac90c22e7c84a40e3ea1718b6e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-01-27 08:58:38 +01:00
parent 8b117bcd86
commit c3f7ef5340
33 changed files with 39 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/perforce/settingspage.cpp
View File

@@ -121,7 +121,7 @@ SettingsPage::SettingsPage(QObject *parent)
: Core::IOptionsPage(parent)
{
setId(VcsBase::Constants::VCS_ID_PERFORCE);
setDisplayName(tr("Perforce"));
setDisplayName(SettingsPageWidget::tr("Perforce"));
setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY);
}

6
src/plugins/perforce/settingspage.h
View File

@@ -38,7 +38,7 @@ struct Settings;
class SettingsPageWidget : public QWidget
{
Q_OBJECT
Q_DECLARE_TR_FUNCTIONS(Perforce::Internal::SettingsPage)
public:
explicit SettingsPageWidget(QWidget *parent = nullptr);
@@ -57,10 +57,8 @@ private:
PerforceChecker *m_checker = nullptr;
};
class SettingsPage : public Core::IOptionsPage
class SettingsPage final : public Core::IOptionsPage
{
Q_OBJECT
public:
explicit SettingsPage(QObject *parent);
~SettingsPage() override;