From c40a802e70c2d0e93d262f437b0524d1f723ccd4 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 16 Aug 2023 08:20:31 +0200 Subject: [PATCH] ProjectExplorer: Postpone set up of kit save connection Does not require early access to ICore::instance(), and there's no point in attempting to save kits before they werde set up. Change-Id: I68953c6019e14e88655ddb46b30ebb9f1916ec46 Reviewed-by: Jarek Kobus --- src/plugins/projectexplorer/kitmanager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/projectexplorer/kitmanager.cpp b/src/plugins/projectexplorer/kitmanager.cpp index b16bb466932..2c95c1edf05 100644 --- a/src/plugins/projectexplorer/kitmanager.cpp +++ b/src/plugins/projectexplorer/kitmanager.cpp @@ -134,8 +134,6 @@ KitManager::KitManager() { d = new KitManagerPrivate; - connect(ICore::instance(), &ICore::saveSettingsRequested, this, &KitManager::saveKits); - connect(this, &KitManager::kitAdded, this, &KitManager::kitsChanged); connect(this, &KitManager::kitRemoved, this, &KitManager::kitsChanged); connect(this, &KitManager::kitUpdated, this, &KitManager::kitsChanged); @@ -151,6 +149,8 @@ void KitManager::restoreKits() { QTC_ASSERT(!d->m_initialized, return ); + connect(ICore::instance(), &ICore::saveSettingsRequested, &KitManager::saveKits); + std::vector> resultList; // read all kits from user file