From c43100c601ed85da8e4aa68f2ff7613809a68a86 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 25 May 2018 17:06:42 +0200 Subject: [PATCH] ProjectExplorer: Simplify SessionManager::markSessionFileDirty(bool) It did nothing if false was passed. So do not call it in that case and drop the parameter. Change-Id: I9b055cb0c0c8be85d528247a269fb7fea062326b Reviewed-by: Eike Ziller --- src/plugins/projectexplorer/session.cpp | 10 ++++------ src/plugins/projectexplorer/session.h | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/plugins/projectexplorer/session.cpp b/src/plugins/projectexplorer/session.cpp index 3f446f282e4..06a33c93e2b 100644 --- a/src/plugins/projectexplorer/session.cpp +++ b/src/plugins/projectexplorer/session.cpp @@ -140,9 +140,9 @@ SessionManager::SessionManager(QObject *parent) : QObject(parent) connect(this, &SessionManager::projectDisplayNameChanged, EditorManager::instance(), &EditorManager::updateWindowTitles); connect(EditorManager::instance(), &EditorManager::editorOpened, - this, [] { markSessionFileDirty(); }); + this, &SessionManager::markSessionFileDirty); connect(EditorManager::instance(), &EditorManager::editorsClosed, - this, [] { markSessionFileDirty(); }); + this, &SessionManager::markSessionFileDirty); EditorManager::setWindowTitleAdditionHandler(&SessionManagerPrivate::windowTitleAddition); EditorManager::setSessionTitleHandler(&SessionManagerPrivate::sessionTitle); @@ -719,7 +719,6 @@ void SessionManager::setValue(const QString &name, const QVariant &value) if (d->m_values.value(name) == value) return; d->m_values.insert(name, value); - markSessionFileDirty(false); } QVariant SessionManager::value(const QString &name) @@ -1052,10 +1051,9 @@ void SessionManager::reportProjectLoadingProgress() d->sessionLoadingProgress(); } -void SessionManager::markSessionFileDirty(bool makeDefaultVirginDirty) +void SessionManager::markSessionFileDirty() { - if (makeDefaultVirginDirty) - d->m_virginSession = false; + d->m_virginSession = false; } void SessionManagerPrivate::sessionLoadingProgress() diff --git a/src/plugins/projectexplorer/session.h b/src/plugins/projectexplorer/session.h index 938a7bc5fee..489536cf755 100644 --- a/src/plugins/projectexplorer/session.h +++ b/src/plugins/projectexplorer/session.h @@ -136,7 +136,7 @@ signals: // for tests only private: static void saveActiveMode(Core::Id mode); static void configureEditor(Core::IEditor *editor, const QString &fileName); - static void markSessionFileDirty(bool makeDefaultVirginDirty = true); + static void markSessionFileDirty(); static void configureEditors(Project *project); };