feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Use a typed root item in ThreadModel

Browse Source 
... and remove casts where possible.

Change-Id: I10305efbe336de7aa5efdb73a52c5f89cd2d089e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2016-06-27 13:46:46 +02:00
parent 06b2df0e27
commit c487217771
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/debugger/threadshandler.cpp
View File

@@ -266,9 +266,9 @@ int ThreadsHandler::currentThreadIndex() const
void ThreadsHandler::sort(int column, Qt::SortOrder order) void ThreadsHandler::sort(int column, Qt::SortOrder order)
{ {
rootItem()->sortChildren([order, column](const TreeItem *item1, const TreeItem *item2) -> bool { rootItem()->sortChildren([order, column](const ThreadItem *item1, const ThreadItem *item2) -> bool {
const QVariant v1 = static_cast<const ThreadItem *>(item1)->threadPart(column); const QVariant v1 = item1->threadPart(column);
const QVariant v2 = static_cast<const ThreadItem *>(item2)->threadPart(column); const QVariant v2 = item2->threadPart(column);
if (v1 == v2) if (v1 == v2)
return false; return false;
if (column == 0) if (column == 0)
@@ -286,7 +286,7 @@ ThreadId ThreadsHandler::currentThread() const
ThreadId ThreadsHandler::threadAt(int index) const ThreadId ThreadsHandler::threadAt(int index) const
{ {
QTC_ASSERT(index >= 0 && index < rootItem()->childCount(), return ThreadId()); QTC_ASSERT(index >= 0 && index < rootItem()->childCount(), return ThreadId());
return static_cast<ThreadItem *>(rootItem()->childAt(index))->threadData.id; return rootItem()->childAt(index)->threadData.id;
} }
void ThreadsHandler::setCurrentThread(ThreadId id) void ThreadsHandler::setCurrentThread(ThreadId id)

2
src/plugins/debugger/threadshandler.h
View File

@@ -41,7 +41,7 @@ namespace Internal {
class GdbMi; class GdbMi;
class ThreadItem; class ThreadItem;
class ThreadsHandler : public Utils::LeveledTreeModel<Utils::TreeItem, ThreadItem> class ThreadsHandler : public Utils::LeveledTreeModel<Utils::TypedTreeItem<ThreadItem>, ThreadItem>
{ {
Q_OBJECT Q_OBJECT