feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

UI text: Use a full stop in the end of messages

Browse Source 
And fix the capitalization of some message box titles.

Task-number: QTCREATORBUG-28334
Change-Id: I858eefd5a12494723c40e0253a3708fa77284d1b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Leena Miettinen
2022-10-19 18:08:39 +02:00
parent d0278ae295
commit c4ac5e414a
16 changed files with 63 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/qmljs/qmljsfindexportedcpptypes.cpp
View File

@@ -251,7 +251,7 @@ protected:
_doc->fileName(),
line, column,
QmlJS::FindExportedCppTypes::tr(
"The type will only be available in the QML editors when the type name is a string literal"));
"The type will only be available in the QML editors when the type name is a string literal."));
return false;
}

14
src/plugins/cppeditor/cppmodelmanager.cpp
View File

@@ -342,19 +342,19 @@ void CppModelManager::showPreprocessedFile(bool inNextSplit)
.arg(reason));
};
static const auto showFallbackWarning = [](const QString &reason) {
Core::MessageManager::writeSilently(Tr::tr("%1, falling back to built-in preprocessor")
Core::MessageManager::writeSilently(Tr::tr("%1, falling back to built-in preprocessor.")
.arg(reason));
};
static const auto saveAndOpen = [](const FilePath &filePath, const QByteArray &contents,
bool inNextSplit) {
SaveFile f(filePath.toString());
if (!f.open()) {
showError(Tr::tr("Failed to open output file \"%1\"").arg(filePath.toUserOutput()));
showError(Tr::tr("Failed to open output file \"%1\".").arg(filePath.toUserOutput()));
return;
}
f.write(contents);
if (!f.commit()) {
showError(Tr::tr("Failed to write output file \"%1\"").arg(filePath.toUserOutput()));
showError(Tr::tr("Failed to write output file \"%1\".").arg(filePath.toUserOutput()));
return;
}
f.close();
@@ -386,7 +386,7 @@ void CppModelManager::showPreprocessedFile(bool inNextSplit)
const Project * const project = ProjectTree::currentProject();
if (!project || !project->activeTarget()
|| !project->activeTarget()->activeBuildConfiguration()) {
showFallbackWarning(Tr::tr("Could not determine which compiler to invoke"));
showFallbackWarning(Tr::tr("Could not determine which compiler to invoke."));
useBuiltinPreprocessor();
return;
}
@@ -398,7 +398,7 @@ void CppModelManager::showPreprocessedFile(bool inNextSplit)
} else if (classifier.isCxx() || classifier.isHeader()) {
tc = ToolChainKitAspect::cxxToolChain(project->activeTarget()->kit());
} else {
showFallbackWarning(Tr::tr("Could not determine which compiler to invoke"));
showFallbackWarning(Tr::tr("Could not determine which compiler to invoke."));
useBuiltinPreprocessor();
return;
}
@@ -408,7 +408,7 @@ void CppModelManager::showPreprocessedFile(bool inNextSplit)
&& (tc->typeId() == ProjectExplorer::Constants::MSVC_TOOLCHAIN_TYPEID
|| tc->typeId() == ProjectExplorer::Constants::CLANG_CL_TOOLCHAIN_TYPEID);
if (!isGcc && !isMsvc) {
showFallbackWarning(Tr::tr("Could not determine compiler command line"));
showFallbackWarning(Tr::tr("Could not determine compiler command line."));
useBuiltinPreprocessor();
return;
}
@@ -418,7 +418,7 @@ void CppModelManager::showPreprocessedFile(bool inNextSplit)
return pp->belongsToProject(ProjectTree::currentProject());
});
if (!projectPart) {
showFallbackWarning(Tr::tr("Could not determine compiler command line"));
showFallbackWarning(Tr::tr("Could not determine compiler command line."));
useBuiltinPreprocessor();
return;
}

4
src/plugins/gitlab/gitlabprojectsettings.cpp
View File

@@ -215,12 +215,12 @@ void GitLabProjectSettingsWidget::onConnectionChecked(const Project &project,
} else {
if (project.accessLevel != -1) {
m_infoLabel->setType(Utils::InfoLabel::Ok);
m_infoLabel->setText(tr("Accessible (%1)")
m_infoLabel->setText(tr("Accessible (%1).")
.arg(accessLevelString(project.accessLevel)));
linkable = true;
} else {
m_infoLabel->setType(Utils::InfoLabel::Warning);
m_infoLabel->setText(tr("Read only access"));
m_infoLabel->setText(tr("Read only access."));
}
}
m_infoLabel->setVisible(true);

4
src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp
View File

@@ -152,8 +152,8 @@ void DynamicPropertiesProxyModel::createProperty(const QString &name, const QStr
const ModelNode modelNode = selectedNodes.constFirst();
if (modelNode.isValid()) {
if (modelNode.hasProperty(name.toUtf8())) {
Core::AsynchronousMessageBox::warning(tr("Property already exists"),
tr("Property '%1' already exists")
Core::AsynchronousMessageBox::warning(tr("Property Already Exists"),
tr("Property \"%1\" already exists.")
.arg(name));
return;
}

4
src/plugins/qmldesigner/components/stateseditor/stateseditormodel.cpp
View File

@@ -170,10 +170,10 @@ void StatesEditorModel::renameState(int internalNodeId, const QString &newName)
if (newName.isEmpty() ||! m_statesEditorView->validStateName(newName)) {
QTimer::singleShot(0, [newName]{
Core::AsynchronousMessageBox::warning(
tr("Invalid state name"),
tr("Invalid State Name"),
newName.isEmpty() ?
tr("The empty string as a name is reserved for the base state.") :
tr("Name already used in another state"));
tr("Name already used in another state."));
});
reset();
} else {

2
src/plugins/studiowelcome/qdsnewdialog.cpp
View File

@@ -87,7 +87,7 @@ QdsNewDialog::QdsNewDialog(QWidget *parent)
m_dialog->installEventFilter(this);
QObject::connect(&m_wizard, &WizardHandler::wizardCreationFailed, this, [this]() {
QMessageBox::critical(m_dialog, tr("New project"), tr("Failed to initialize data"));
QMessageBox::critical(m_dialog, tr("New Project"), tr("Failed to initialize data."));
reject();
delete this;
});