diff --git a/src/plugins/android/androiddebugsupport.cpp b/src/plugins/android/androiddebugsupport.cpp index 17f608e4246..11fabdccfdb 100644 --- a/src/plugins/android/androiddebugsupport.cpp +++ b/src/plugins/android/androiddebugsupport.cpp @@ -143,10 +143,6 @@ void AndroidDebugSupport::start() addSearchDirectory(qtVersion->qmlPath().toString()); } - // FIXME: Move signal to base class and generalize handling. - connect(this, &DebuggerRunTool::aboutToNotifyInferiorSetupOk, - m_runner, &AndroidRunner::remoteDebuggerRunning); - DebuggerRunTool::start(); } diff --git a/src/plugins/android/androidrunner.cpp b/src/plugins/android/androidrunner.cpp index b4e3d11e9a0..a6fbafec5be 100644 --- a/src/plugins/android/androidrunner.cpp +++ b/src/plugins/android/androidrunner.cpp @@ -155,8 +155,6 @@ AndroidRunner::AndroidRunner(RunControl *runControl, connect(this, &AndroidRunner::asyncStop, m_worker.data(), &AndroidRunnerWorkerBase::asyncStop); connect(this, &AndroidRunner::androidRunnableChanged, m_worker.data(), &AndroidRunnerWorkerBase::setAndroidRunnable); - connect(this, &AndroidRunner::remoteDebuggerRunning, - m_worker.data(), &AndroidRunnerWorkerBase::handleRemoteDebuggerRunning); connect(m_worker.data(), &AndroidRunnerWorkerBase::remoteProcessStarted, this, &AndroidRunner::handleRemoteProcessStarted); diff --git a/src/plugins/android/androidrunner.h b/src/plugins/android/androidrunner.h index fc6b4e64701..4c6b90a0f82 100644 --- a/src/plugins/android/androidrunner.h +++ b/src/plugins/android/androidrunner.h @@ -69,7 +69,6 @@ public: signals: void asyncStart(); void asyncStop(); - void remoteDebuggerRunning(); void qmlServerReady(const QUrl &serverUrl); void androidRunnableChanged(const AndroidRunnable &runnable); void avdDetected(); diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp index 11ae7d3db81..fd96fd62ee1 100644 --- a/src/plugins/android/androidrunnerworker.cpp +++ b/src/plugins/android/androidrunnerworker.cpp @@ -440,9 +440,6 @@ void AndroidRunnerWorkerBase::asyncStop() m_gdbServerProcess.reset(); } -void AndroidRunnerWorkerBase::handleRemoteDebuggerRunning() -{} - void AndroidRunnerWorkerBase::handleJdbWaiting() { QStringList removeForward{"forward", "--remove", "tcp:" + m_localJdbServerPort.toString()}; diff --git a/src/plugins/android/androidrunnerworker.h b/src/plugins/android/androidrunnerworker.h index 686104758c7..9781d27e8cf 100644 --- a/src/plugins/android/androidrunnerworker.h +++ b/src/plugins/android/androidrunnerworker.h @@ -71,7 +71,6 @@ public: virtual void asyncStart(); virtual void asyncStop(); - virtual void handleRemoteDebuggerRunning(); virtual void handleJdbWaiting(); virtual void handleJdbSettled(); diff --git a/src/plugins/debugger/debuggerengine.cpp b/src/plugins/debugger/debuggerengine.cpp index 4df97238907..df8ae8d5dc7 100644 --- a/src/plugins/debugger/debuggerengine.cpp +++ b/src/plugins/debugger/debuggerengine.cpp @@ -650,12 +650,9 @@ void DebuggerEngine::notifyEngineSetupOk() d->m_progress.setProgressValue(250); QTC_ASSERT(state() == EngineSetupRequested, qDebug() << this << state()); setState(EngineSetupOk); - if (isMasterEngine() && runTool()) { - runTool()->aboutToNotifyInferiorSetupOk(); // FIXME: Remove, only used for Android. - runTool()->reportStarted(); - } - if (isMasterEngine()) { + if (runTool()) + runTool()->reportStarted(); // Slaves will get called setupSlaveInferior() below. setState(EngineRunRequested); showMessage("CALL: RUN ENGINE"); diff --git a/src/plugins/debugger/debuggerruncontrol.h b/src/plugins/debugger/debuggerruncontrol.h index f0c865316ec..b7f7a468820 100644 --- a/src/plugins/debugger/debuggerruncontrol.h +++ b/src/plugins/debugger/debuggerruncontrol.h @@ -136,9 +136,6 @@ public: Internal::TerminalRunner *terminalRunner() const; -signals: - void aboutToNotifyInferiorSetupOk(); - private: bool fixupParameters();